From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Franziska Naepelt <franziska.naepelt@googlemail.com>,
linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-kernel@vger.kernel.org,
Franziska Naepelt <franziska.naepelt@gmail.com>,
Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
James Morris <jmorris@intercode.com.au>,
Steve French <sfrench@samba.org>
Subject: Re: [PATCH] crypto: md4: Fix checkpatch issues
Date: Tue, 6 Jun 2023 19:22:32 +0700 [thread overview]
Message-ID: <a26e0d90-091e-07c0-40d2-b81445103a25@gmail.com> (raw)
In-Reply-To: <CAMj1kXHqn_Kff94s3zWZD5k5MvJQs-GGkFLC_tLJQLNDJgXHHA@mail.gmail.com>
On 6/6/23 19:18, Ard Biesheuvel wrote:
> On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
>>> The following checkpatch issues have been fixed:
>>> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>>> - ERROR: space required after that ',' (ctx:VxV)
>>> - ERROR: space prohibited after that open square bracket '['
>>> - WARNING: space prohibited between function name and open parenthesis '('
>>> - ERROR: code indent should use tabs where possible
>>
>> Again, please split up into one patch per fixes, as a patch series.
>>
>
> Apart from the SPDX conversion, I think it is fine to fix multiple
> different whitespace issues in the same file with one patch. Splitting
> that up is just busywork.
>
Do you mean SPDX conversion in one patch and the rest in another? I think
so and confused...
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2023-06-06 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230606112610.98149-1-franziska.naepelt@gmail.com>
2023-06-06 12:14 ` [PATCH] crypto: md4: Fix checkpatch issues Bagas Sanjaya
2023-06-06 12:18 ` Ard Biesheuvel
2023-06-06 12:22 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26e0d90-091e-07c0-40d2-b81445103a25@gmail.com \
--to=bagasdotme@gmail.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=franziska.naepelt@gmail.com \
--cc=franziska.naepelt@googlemail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@intercode.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).