From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Franziska Naepelt <franziska.naepelt@googlemail.com>,
linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-kernel@vger.kernel.org,
Franziska Naepelt <franziska.naepelt@gmail.com>,
Linux SPDX Licenses <linux-spdx@vger.kernel.org>,
Linux Kernel Janitors <kernel-janitors@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] crypto: frcypt Fix checkpatch warnings
Date: Tue, 6 Jun 2023 18:36:43 +0700 [thread overview]
Message-ID: <ZH8aS-rMMKaxRD50@debian.me> (raw)
In-Reply-To: <20230606111042.96855-1-franziska.naepelt@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]
[Also Cc: linux-spdx list and original author mentioned in the license
boilerplate]
On Tue, Jun 06, 2023 at 01:10:42PM +0200, Franziska Naepelt wrote:
> The following checkpatch warnings have been fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - WARNING: Block comments use a trailing */ on a separate line
Two different logical changes in a patch - please break them into a
2-patch series, with each patch do one job. And please write the patch
description in imperative mood instead (e.g. "Do foo").
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /* FCrypt encryption algorithm
> *
> * Copyright (C) 2006 Red Hat, Inc. All Rights Reserved.
NAK!
There is also BSD 3-clause boilerplate (from original code that fcrypt.c
is based on). Thus, the proper SPDX tag should have been:
```
// SPDX-License-Identifier: GPL-2.0-or-later AND BSD-3-Clause
```
And please also delete the boilerplate.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
parent reply other threads:[~2023-06-06 11:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230606111042.96855-1-franziska.naepelt@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH8aS-rMMKaxRD50@debian.me \
--to=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=franziska.naepelt@gmail.com \
--cc=franziska.naepelt@googlemail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).