From: Thomas Gleixner <tglx@linutronix.de>
To: Christoph Hellwig <hch@infradead.org>,
Nicky Chorley <ndchorley@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-spdx@vger.kernel.org
Subject: Re: Fwd: scripts/spdxcheck.py's third-party dependencies
Date: Tue, 10 Aug 2021 23:00:56 +0200 [thread overview]
Message-ID: <87pmulovzr.ffs@tglx> (raw)
In-Reply-To: <YRKv6cpxaUfa6Abv@infradead.org>
On Tue, Aug 10 2021 at 17:57, Christoph Hellwig wrote:
> On Fri, Aug 06, 2021 at 07:44:41AM +0100, Nicky Chorley wrote:
>> On Thu, 5 Aug 2021, Greg KH wrote:
>>
>> > But we do not use pip to do kernel builds, so what is this going to help
>> > with?
>>
>> It's just about making people's lives easier for running the spdxcheck.py
>> script - not everyone will have the third-party libraries installed, so
>> listing them means they can be installed easily. For example:
>
> I think the most useful thing here would be to find a way to make
> spdxcheck just work without the non-standard python module. As far
> as I can tell it uses the module only to do the recursive travesal
> of the current tree anyway, which seems rather pointless to start with.
Yes, it's just the tree traversal and it turned out to be convenient to
just use the git python bindings to avoid scanning random crap in the
source tree. It should be simple enough to make it use the output of a
subprocess running 'git ls-files'.
But python-git is packaged in most distros, so when I wrote this script
I really could not be bothered to deal with parsing subprocess output
and aside of that resolving:
ModuleNotFoundError: No module named 'git'
is not rocket science by any means.
Thanks,
tglx
prev parent reply other threads:[~2021-08-10 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <efcdf26-fd74-3d7d-25b1-d77ed3c493@rigel.lan>
2021-07-27 6:42 ` Fwd: scripts/spdxcheck.py's third-party dependencies Nicky Chorley
2021-07-27 6:47 ` Greg KH
2021-07-31 11:57 ` Nicky Chorley
2021-08-05 12:21 ` Greg KH
2021-08-06 6:44 ` Nicky Chorley
2021-08-10 11:27 ` Zavras, Alexios
2021-08-10 16:57 ` Christoph Hellwig
2021-08-10 21:00 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmulovzr.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-spdx@vger.kernel.org \
--cc=ndchorley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).