From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Richard Fontana" <rfontana@redhat.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Linux SPDX Licenses" <linux-spdx@vger.kernel.org>,
"Linux DRI Development" <dri-devel@lists.freedesktop.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Networking" <netdev@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Linux Staging Drivers" <linux-staging@lists.linux.dev>,
"Linux Watchdog Devices" <linux-watchdog@vger.kernel.org>,
"Linux Kernel Actions" <linux-actions@lists.infradead.org>,
"Diederik de Haas" <didi.debian@cknow.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"David Airlie" <airlied@redhat.com>,
"Karsten Keil" <isdn@linux-pingi.de>,
"Jay Vosburgh" <j.vosburgh@gmail.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Sam Creasey" <sammy@sammy.net>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Jan Kara" <jack@suse.com>, "Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Ray Lehtiniemi" <rayl@mail.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Andrey Panin" <pazke@donpac.ru>,
"Oleg Drokin" <green@crimea.edu>, "Marc Zyngier" <maz@kernel.org>,
"Jonas Jensen" <jonas.jensen@gmail.com>,
"Sylver Bruneau" <sylver.bruneau@googlemail.com>,
"Andrew Sharp" <andy.sharp@lsi.com>,
"Denis Turischev" <denis@compulab.co.il>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Alan Cox" <alan@linux.intel.com>,
"Simon Horman" <simon.horman@corigine.com>
Subject: Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier
Date: Sun, 14 May 2023 06:08:29 -0700 [thread overview]
Message-ID: <511814a0-0c42-4813-9473-13748d6c6cb0@roeck-us.net> (raw)
In-Reply-To: <2023051414-headroom-maimed-553c@gregkh>
On Sun, May 14, 2023 at 12:07:28AM +0900, Greg Kroah-Hartman wrote:
> On Sat, May 13, 2023 at 09:43:39AM -0400, Richard Fontana wrote:
> > On Sat, May 13, 2023 at 6:53 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > >
> > > On 5/12/23 19:46, Richard Fontana wrote:
> > > > On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > > >
> > > >
> > > >> diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
> > > >> index 504be461f992a9..822bf8905bf3ce 100644
> > > >> --- a/drivers/watchdog/sb_wdog.c
> > > >> +++ b/drivers/watchdog/sb_wdog.c
> > > >> @@ -1,3 +1,4 @@
> > > >> +// SPDX-License-Identifier: GPL-1.0+
> > > >> /*
> > > >> * Watchdog driver for SiByte SB1 SoCs
> > > >> *
> > > >> @@ -38,10 +39,6 @@
> > > >> * (c) Copyright 1996 Alan Cox <alan@lxorguk.ukuu.org.uk>,
> > > >> * All Rights Reserved.
> > > >> *
> > > >> - * This program is free software; you can redistribute it and/or
> > > >> - * modify it under the terms of the GNU General Public License
> > > >> - * version 1 or 2 as published by the Free Software Foundation.
> > > >
> > > > Shouldn't this be
> > > > // SPDX-License-Identifier: GPL-1.0 OR GPL-2.0
> > > > (or in current SPDX notation GPL-1.0-only OR GPL-2.0-only) ?
> > > >
> > >
> > > Nope, as it will fail spdxcheck.py. Also, SPDX specification [1]
> > > doesn't have negation operator (NOT), thus the licensing requirement
> > > on the above notice can't be expressed reliably in SPDX here.
> > >
> > > [1]: https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/
> >
> > The GPL identifiers in recent versions of SPDX include an `-only` and
> > an `-or-later` variant.
>
> But Linux does not use the newer versions of SPDX given that we started
> the conversion before the "-only" variant came out. Let's stick with
> the original one please before worrying about converting to a newer
> version of SPDX and mixing things up.
>
Either case I'd prefer to have no conversion if there is no means
to express the original license (ie GPL-1.0 or GPL-2.0 and nothing else)
in acceptable SPDX form.
Thanks,
Guenter
next prev parent reply other threads:[~2023-05-14 13:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 10:06 [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 01/10] agp/amd64: Remove GPL distribution notice Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 03/10] net: bonding: Add SPDX identifier to remaining files Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier Bagas Sanjaya
2023-05-12 11:27 ` Geert Uytterhoeven
2023-05-12 13:03 ` Richard Fontana
2023-05-12 10:06 ` [PATCH v2 05/10] net: ethernet: i825xx: " Bagas Sanjaya
2023-05-12 11:21 ` Greg Kroah-Hartman
2023-05-12 10:06 ` [PATCH v2 06/10] pcmcia: Add " Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 07/10] drivers: staging: wlan-ng: Remove GPL/MPL boilerplate Bagas Sanjaya
2023-05-12 10:06 ` [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier Bagas Sanjaya
2023-05-12 12:46 ` Richard Fontana
2023-05-13 10:52 ` Bagas Sanjaya
2023-05-13 13:43 ` Richard Fontana
2023-05-13 15:07 ` Greg Kroah-Hartman
2023-05-14 13:08 ` Guenter Roeck [this message]
2023-05-12 12:49 ` Guenter Roeck
2023-05-12 12:50 ` Bagas Sanjaya
2023-05-12 13:14 ` Andreas Färber
2023-05-12 10:06 ` [PATCH v2 09/10] udf: Replace " Bagas Sanjaya
2023-05-12 13:21 ` Richard Fontana
2023-05-13 9:31 ` Bagas Sanjaya
2023-05-13 9:48 ` Pali Rohár
2023-05-13 9:59 ` Greg Kroah-Hartman
2023-05-12 10:06 ` [PATCH v2 10/10] include: synclink: Replace GPL " Bagas Sanjaya
2023-05-12 11:23 ` [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Greg Kroah-Hartman
2023-05-13 9:25 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511814a0-0c42-4813-9473-13748d6c6cb0@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=airlied@redhat.com \
--cc=alan@linux.intel.com \
--cc=andy.sharp@lsi.com \
--cc=andy@greyhouse.net \
--cc=bagasdotme@gmail.com \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=denis@compulab.co.il \
--cc=didi.debian@cknow.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=green@crimea.edu \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=j.vosburgh@gmail.com \
--cc=jack@suse.com \
--cc=jonas.jensen@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pazke@donpac.ru \
--cc=pombredanne@nexb.com \
--cc=rayl@mail.com \
--cc=rfontana@redhat.com \
--cc=robert.jarzmik@free.fr \
--cc=sammy@sammy.net \
--cc=simon.horman@corigine.com \
--cc=sylver.bruneau@googlemail.com \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).