From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] sparse v0.6.4 regression
Date: Sun, 22 May 2022 16:06:27 +0100 [thread overview]
Message-ID: <c07296ee-650a-7261-5acb-75013b909d9b@ramsayjones.plus.com> (raw)
In-Reply-To: <20220521094418.pf6s4usfq4npktn6@mail>
On 21/05/2022 10:44, Luc Van Oostenryck wrote:
> On Tue, Sep 28, 2021 at 12:41:27AM +0100, Ramsay Jones wrote:
> Hi Ramsay,
Hi Luc, good to hear from you! Hope you are keeping well.
>> I noticed a regression introduced by commit a69f8d70 which, effectively,
>> disables the 'memcpy-max-count' check. (I had done a 'make CC=cgcc' in
>> git, expecting to see some warnings, including the 'memcpy-max-count'
>> check, and it didn't appear ... :( ). Sorry for not noticing before, but
>> the 'sparse' make target is supposed to suppress that warning for the
>> pack-revindex.c file, so ... ;P
>>
>> [I tried finding your last 'kernel sparse warnings change' list email
>> to see how many of these warnings still appear in the kernel ... well
>> it would be zero with v0.6.4!]
>
> Now I can see 4 of them.
I tested today's master (@commit fbdc046e (Use offsetof macro to silence
null ptr subtraction warning, 2022-03-21)), without issue on 64-bit
linux and cygwin. (so, not 32-bit linux, which requires a reboot ...)
Also, a 'make CC=cgcc' now issues all the warnings I expect, including:
CC pack-revindex.o
pack-revindex.c:73:23: warning: memset with byte count of 262144
I noticed that three RISC-V patches have been pushed since then, so I will
test those later ...
>> I also included the 'case label' patch I sent before, this time with
>> a commit message and a test. (The test could be extended when sparse
>> is updated to include the full label-positioning of C23!).
>
> Thank you very much, pushed now, and ...
Thanks!
> apologies for this huge delay.
No problem.
ATB,
Ramsay Jones
prev parent reply other threads:[~2022-05-22 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 23:41 [PATCH 0/2] sparse v0.6.4 regression Ramsay Jones
2022-05-21 9:44 ` Luc Van Oostenryck
2022-05-22 15:06 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c07296ee-650a-7261-5acb-75013b909d9b@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=gitster@pobox.com \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).