From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Herve Codina <herve.codina@bootlin.com>
Cc: Luc Van Oostenryck <lucvoo@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
linux-sparse@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] parse: handle __cleanup__ attribute
Date: Thu, 29 Feb 2024 16:03:03 +0200 [thread overview]
Message-ID: <ZeCOlzq6qLJtuc0O@smile.fi.intel.com> (raw)
In-Reply-To: <Zag2fYsyJDtDR7a6@google.com>
On Wed, Jan 17, 2024 at 12:20:13PM -0800, Dmitry Torokhov wrote:
> On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote:
> > On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote:
> > > Yep. Perfect. Thanks so much!
> >
> > Pushed now.
>
> Any chance someone is looking at making context tracking working for
> code annotated as __cleanup? We already have a bunch of code using
> constructs like:
>
> ...
> guard(spinlock_irqsave)(&gpio_lock);
>
> if (!test_bit(FLAG_REQUESTED, &desc->flags))
> return NULL;
> ...
>
> which resuls in:
>
> $ make C=1 W=1 drivers/gpio/gpiolib.o
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> INSTALL libsubcmd_headers
> CC drivers/gpio/gpiolib.o
> CHECK drivers/gpio/gpiolib.c
> drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block
>
> and I expect we'll see more and more of this.
+1 here. It's quite annoying for every Linux kernel developer in the world
(which are at least 2k of active ones).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-29 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 9:49 [PATCH v2] parse: handle __cleanup__ attribute Dan Carpenter
2023-12-11 13:16 ` Luc Van Oostenryck
2023-12-12 9:39 ` Dan Carpenter
2023-12-13 10:14 ` Dan Carpenter
2023-12-14 13:05 ` Luc Van Oostenryck
2023-12-14 13:20 ` Dan Carpenter
2023-12-18 13:51 ` Luc Van Oostenryck
2024-01-17 20:20 ` Dmitry Torokhov
2024-02-29 14:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeCOlzq6qLJtuc0O@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=lucvoo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).