From: "GONG, Ruiqi" <gongruiqi@huaweicloud.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, gongruiqi1@huawei.com,
linux-sparse@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] pinctrl: renesas: remove checker warnings: x | !y
Date: Tue, 13 Jun 2023 17:45:28 +0800 [thread overview]
Message-ID: <4a501c9f-245f-5ecd-46e9-dc0e71abf8a5@huaweicloud.com> (raw)
In-Reply-To: <CAMuHMdXGG2xu+nXJt6CSTfV6aM=U=hMW+DiDgP3RhOw8+O8y=A@mail.gmail.com>
Hi Geert,
On 2023/06/13 15:38, Geert Uytterhoeven wrote:
> Hi Gong,
>
> On Tue, Jun 13, 2023 at 4:13 AM GONG, Ruiqi <gongruiqi@huaweicloud.com> wrote:
>> Eliminate the following Sparse reports when building with C=1:
>>
>> drivers/pinctrl/renesas/pinctrl-rzn1.c:187:52: warning: dubious: x | !y
>> drivers/pinctrl/renesas/pinctrl-rzn1.c:193:52: warning: dubious: x | !y
>>
>> Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
>
> Thanks for your patch!
>
> Looks like sparse needs to be taught the "|" is not used in a boolean
> context here?
Okay after reading the source code of Sparse I think what this kind of
warnings actually means is to hint us a possible misuse of "|" instead
of "||" (i.e. misusing a binary operator in a conditional context). Here
the code is doing binary operation (i.e. to flip a bit or two), so in
this sense the warnings should be just false alarms.
However, the original code is a bit weird for me because of the sudden
appearance of a boolean operator (i.e. "!") in the middle of a binary
calculation. And I think it looks better after this change, since it
makes the expression look more "binary". So maybe we can still consider
apply this change ;)
Greetings,
Ruiqi
>
>> --- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
>> +++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
>> @@ -184,13 +184,15 @@ static void rzn1_hw_set_lock(struct rzn1_pinctrl *ipctl, u8 lock, u8 value)
>> * address | 1.
>> */
>> if (lock & LOCK_LEVEL1) {
>> - u32 val = ipctl->lev1_protect_phys | !(value & LOCK_LEVEL1);
>> + u32 val = ipctl->lev1_protect_phys |
>> + (value & LOCK_LEVEL1 ? 0 : 1);
>>
>> writel(val, &ipctl->lev1->status_protect);
>> }
>>
>> if (lock & LOCK_LEVEL2) {
>> - u32 val = ipctl->lev2_protect_phys | !(value & LOCK_LEVEL2);
>> + u32 val = ipctl->lev2_protect_phys |
>> + (value & LOCK_LEVEL2 ? 0 : 1);
>>
>> writel(val, &ipctl->lev2->status_protect);
>> }
>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2023-06-13 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230613021643.3330661-1-gongruiqi@huaweicloud.com>
2023-06-13 7:38 ` [PATCH] pinctrl: renesas: remove checker warnings: x | !y Geert Uytterhoeven
2023-06-13 8:37 ` Dan Carpenter
2023-06-13 9:45 ` GONG, Ruiqi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a501c9f-245f-5ecd-46e9-dc0e71abf8a5@huaweicloud.com \
--to=gongruiqi@huaweicloud.com \
--cc=dan.carpenter@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gongruiqi1@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).