From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
kernel test robot <lkp@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-staging@lists.linux.dev,
"open list:TI ETHERNET SWITCH DRIVER (CPSW)"
<linux-omap@vger.kernel.org>,
linux-nvme@lists.infradead.org, linux-hwmon@vger.kernel.org,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-sparse@vger.kernel.org,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3
Date: Sun, 22 May 2022 13:57:00 +0200 [thread overview]
Message-ID: <20220522115700.vg4hsytav74sy3x6@mail> (raw)
In-Reply-To: <CAMuHMdVx7r-4TVV9uVJppT-7ZAriov01BUNk4ghU9Bs4uY28vQ@mail.gmail.com>
On Fri, May 20, 2022 at 02:46:20PM +0200, Geert Uytterhoeven wrote:
> > The "(void)" makes sure there is no return value.
> > Which matters if the result of a function returning void is propagated
> > to another function returning void.
>
> Which, FTR, sparse also doesn't like:
>
> error: return expression in void function
You should get this message only if the expression is itself not void.
For example:
$ cat test.c
extern void fun(void);
static void ko(int *ptr)
{
return *ptr;
}
static void ok1(int *ptr)
{
return (void) *ptr;
}
static void ok2(int *ptr)
{
return fun();
}
$ sparse test.c
test.c:5:16: error: return expression in void function
IOW, sparse warn only for the ko() but not for ok1() or ok2().
If you have a case whee it s not the case, please send me the
pre-processed file and I'll be glad to investigate.
Best regards,
-- Luc
next prev parent reply other threads:[~2022-05-22 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6285958d.+Z2aDZ4O1Y9eiazd%lkp@intel.com>
[not found] ` <0530d502-1291-23f3-64ac-97bd38a26bd4@roeck-us.net>
2022-05-20 12:40 ` [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Geert Uytterhoeven
2022-05-20 12:46 ` Geert Uytterhoeven
2022-05-22 11:57 ` Luc Van Oostenryck [this message]
2022-05-22 11:44 ` Luc Van Oostenryck
2022-05-22 11:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220522115700.vg4hsytav74sy3x6@mail \
--to=luc.vanoostenryck@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).