From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: sparse attribute packed on structures
Date: Thu, 17 Dec 2020 01:57:36 +0100 [thread overview]
Message-ID: <20201217005736.xac6ryxknyqs7usy@ltop.local> (raw)
In-Reply-To: <09a4e340-76d4-9ae3-ffe3-6e44706200ae@intel.com>
On Wed, Dec 16, 2020 at 04:43:24PM -0800, Jacob Keller wrote:
> On 12/16/2020 3:30 PM, Luc Van Oostenryck wrote:
> > On Tue, Dec 15, 2020 at 03:15:48PM -0800, Jacob Keller wrote:
> >>
> >> I did find one bug, in your step (3), you have a check against
> >> info->packed on symbol.c:162 in lay_out_struct, but nothing ever set the
> >> packed value. I think you just need to initialized info->packed from
> >> sym_packed at the top of examine_struct_union_type, i.e.
> >
> > A yes, I see, thank you. I think it was on purpose that it wasn't
> > yet enabled (things are it fuzzy because the code is ~2 year old)
> > and as I said it's unfinished.
> >
> > But, with your change, does it handles 'packed' more or less
> > correctly?
> >
> > -- Luc
> >
>
> Yes. Obviously we're limited in that we no longer check for
> out-of-bounds accesses on bitfields, but it at least produces the
> correct sizes for structures, and avoids the warnings that I was running
> into.
Nice, thanks for confirming this.
> Overall, I think the changes in that branch are solid, and look correct
> to me.
>
> I'm not sure what all the limitations are of having it produce incorrect
> load/store operations that don't work with the packed bitfields.. but at
> least for the code I was checking, it seems to be correct now.
Oh, it's not much, just the usual. Currently, sparse always access a
bitfield with its base type. So, if we have the following:
struct foo {
int a;
int b:24;
} __packed;
struct foo s;
Then accessing s.b will first load the full word and then mask the
upper bits, but:
1) this will access bytes 5,6,7 & 8 but the structure is only 7 bytes
long and so the access checking should fail.
2) accessing byte-by-byte and then assemble the result is endian
specific and until now sparse had succeed o ignore this kind
of 'details'.
-- Luc
prev parent reply other threads:[~2020-12-17 0:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:15 sparse attribute packed on structures Jacob Keller
2020-12-15 20:56 ` Luc Van Oostenryck
2020-12-15 22:17 ` Jacob Keller
2020-12-15 22:44 ` Jacob Keller
2020-12-15 23:15 ` Jacob Keller
2020-12-16 23:30 ` Luc Van Oostenryck
2020-12-17 0:43 ` Jacob Keller
2020-12-17 0:57 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217005736.xac6ryxknyqs7usy@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).