From: John Hubbard <jhubbard@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Ivan Orlov <ivan.orlov0322@gmail.com>,
linux-sound@vger.kernel.org,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH] selftests/alsa: fix a build warning: return a value in all cases
Date: Sun, 5 May 2024 13:57:47 -0700 [thread overview]
Message-ID: <cf87f691-c2db-4a24-bf33-af26adffcafa@nvidia.com> (raw)
In-Reply-To: <ZjedcAW6ITmo9pXp@finisterre.sirena.org.uk>
On 5/5/24 7:53 AM, Mark Brown wrote:
> On Fri, May 03, 2024 at 07:13:30PM -0700, John Hubbard wrote:
>> dump_config_tree() is declared to return an int, but the compiler cannot
>> prove that it always returns any value at all. This leads to a clang
>> warning, when building via:
>
> Though given that the function isn't referenced we could also just
> delete it.
Even better, thanks for spotting that. I'll send a v2 to delete it.
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2024-05-05 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 2:13 [PATCH] selftests/alsa: fix a build warning: return a value in all cases John Hubbard
2024-05-05 14:52 ` Mark Brown
2024-05-05 14:53 ` Mark Brown
2024-05-05 20:57 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf87f691-c2db-4a24-bf33-af26adffcafa@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=broonie@kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).