From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Alexandre Mergnat" <amergnat@baylibre.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lee Jones" <lee@kernel.org>, "Flora Fu" <flora.fu@mediatek.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Rob Herring" <robh@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document
Date: Thu, 25 Apr 2024 08:38:29 +0200 [thread overview]
Message-ID: <b48d5d30-61b0-4c11-8afd-1c07cbe05400@linaro.org> (raw)
In-Reply-To: <a8730bb5-4f51-4c75-b049-6f00e3de5855@baylibre.com>
On 23/04/2024 19:07, Alexandre Mergnat wrote:
>
>
> On 09/04/2024 17:55, Krzysztof Kozlowski wrote:
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + codec {
>>> + mediatek,micbias0-microvolt = <1900000>;
>>> + mediatek,micbias1-microvolt = <1700000>;
>>> + mediatek,vaud28-supply = <&mt6357_vaud28_reg>;
>> Sorry, this does not work. Change voltage to 1111111 and check the results.
>
> Actually it's worst ! I've removed the required property (vaud28-supply) but the dt check pass.
> Same behavior for some other docs like mt6359.yaml
Yeah, the schema is not applied. There is nothing selecting it, so this
is no-op schema. I don't know what exactly you want to describe, but
usually either you miss compatible or this should be just part of parent
node.
>
> The at24.yaml doc works as expected, then I tried compare an find the issue, without success...
>
> I've replaced "codec" by "audio-codec", according to [1].
> I've tried multiple manner to implement the example code, without success. I'm wondering if what I
> try to do is the correct way or parse-able by the dt_check.
>
> If I drop this file and implement all these new properties into the MFD PMIC documentation directly,
> I've the expected dt_check result (function to good or wrong parameters)
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-25 6:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 13:41 [PATCH v3 00/18] Add audio support for the MediaTek Genio 350-evk board Alexandre Mergnat
2024-04-09 13:41 ` [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document Alexandre Mergnat
2024-04-09 15:46 ` Krzysztof Kozlowski
2024-04-10 9:29 ` Alexandre Mergnat
2024-04-13 21:44 ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 02/18] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document Alexandre Mergnat
2024-04-09 15:51 ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document Alexandre Mergnat
2024-04-09 15:55 ` Krzysztof Kozlowski
2024-04-23 17:07 ` Alexandre Mergnat
2024-04-25 6:38 ` Krzysztof Kozlowski [this message]
2024-04-09 13:42 ` [PATCH v3 04/18] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC Alexandre Mergnat
2024-04-09 15:56 ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 05/18] ASoC: mediatek: mt8365: Add common header Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 06/18] SoC: mediatek: mt8365: support audio clock control Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 07/18] ASoC: mediatek: mt8365: Add I2S DAI support Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 08/18] ASoC: mediatek: mt8365: Add ADDA " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 09/18] ASoC: mediatek: mt8365: Add DMIC " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 10/18] ASoC: mediatek: mt8365: Add PCM " Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 11/18] ASoc: mediatek: mt8365: Add a specific soundcard for EVK amergnat
2024-04-09 13:42 ` [PATCH v3 12/18] ASoC: mediatek: mt8365: Add platform driver Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 13/18] ASoC: codecs: add MT6357 support amergnat
2024-04-09 13:42 ` [PATCH v3 14/18] ASoC: mediatek: Add MT8365 support Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 15/18] arm64: defconfig: enable mt8365 sound Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 16/18] arm64: dts: mediatek: add mt6357 audio codec support Alexandre Mergnat
2024-04-09 15:58 ` Krzysztof Kozlowski
2024-04-09 13:42 ` [PATCH v3 17/18] arm64: dts: mediatek: add afe support for mt8365 SoC Alexandre Mergnat
2024-04-09 13:42 ` [PATCH v3 18/18] arm64: dts: mediatek: add audio support for mt8365-evk Alexandre Mergnat
2024-04-09 16:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48d5d30-61b0-4c11-8afd-1c07cbe05400@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=flora.fu@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).