From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Pietro Caruso <pietrocaruso50@gmail.com>
Subject: Re: [PATCH 00/10] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock
Date: Tue, 23 Apr 2024 09:21:43 +0200 [thread overview]
Message-ID: <Zidhh8XJwUr6Y2kh@ugly> (raw)
In-Reply-To: <871q6xjiw8.wl-tiwai@suse.de>
On Mon, Apr 22, 2024 at 09:29:27PM +0200, Takashi Iwai wrote:
>On Sun, 21 Apr 2024 22:46:57 +0200,
>Oswald Buddenhagen wrote:
>>
>> patches 1-3 & 5 fix the regression(s), patch 4 fixes a related pre-existing
>> problem, while patches 6-10 are "only" improvements.
>>
>If a few of the series are rather regression fixes that should be
>merged to Linus tree sooner, please separate them and send two patch
>sets instead.
>
i can't give more precise instructions than above; it's a judgment call
whether you consider patch 4 urgent enough (it's a fix, but not for a
recently introduced regression; nonetheless, i've seen less important
patches from me be picked to stable). i'd just split the series in half.
>I don't see Fixes tag in the patch 2, for example, so
>I'm not sure whether I should pick up.
>
as the commit message says, it's preparatory refactoring for patch 3, so
it's not a fix, but a mandatory dependency for one.
>Also, your Fixes tag usage is incorrect. It should be
> Fixes: $ID ("subject...")
>while yours missing the quotes. Some people are picky about those
>formats, so let's be strict.
>
fair enough.
prev parent reply other threads:[~2024-04-23 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 20:46 [PATCH 00/10] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock Oswald Buddenhagen
2024-04-21 20:46 ` [PATCH 01/10] ALSA: emu10k1: fix E-MU card dock presence monitoring Oswald Buddenhagen
2024-04-21 20:46 ` [PATCH 02/10] ALSA: emu10k1: factor out snd_emu1010_load_dock_firmware() Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 03/10] ALSA: emu10k1: move the whole GPIO event handling to the workqueue Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 04/10] ALSA: emu10k1: use mutex for E-MU FPGA access locking Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 05/10] ALSA: emu10k1: fix E-MU dock initialization Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 06/10] ALSA: emu10k1: simplify E-MU card FPGA reset sequence Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 07/10] ALSA: emu10k1: make snd_emu1010_load_firmware_entry() void Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 08/10] ALSA: emu10k1: move entering E-MU card FPGA programming mode Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 09/10] ALSA: emu10k1: move snd_emu1010_load_firmware_entry() to io.c Oswald Buddenhagen
2024-04-21 20:47 ` [PATCH 10/10] ALSA: emu10k1: make E-MU FPGA writes potentially more reliable Oswald Buddenhagen
2024-04-22 19:29 ` [PATCH 00/10] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock Takashi Iwai
2024-04-23 7:21 ` Oswald Buddenhagen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zidhh8XJwUr6Y2kh@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pietrocaruso50@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).