From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Takashi Iwai <tiwai@suse.de>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-sound@vger.kernel.org
Subject: regression/bisected/6.9 commit 587d67fd929ad89801bcc429675bda90d53f6592 decrease 30% of gaming performance
Date: Mon, 1 Apr 2024 01:21:20 +0500 [thread overview]
Message-ID: <CABXGCsNmEtrN9DK-XmESaPm_1xpXm8A+juE+44Jf6AK5JE0+TQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
Hi,
I spotted that FPS was around 122 [1] in the Shadow of the Tomb Raider
benchmark at commit f6cef5f8c37f but after moving to commit
4ae3dc83b047 it decreased to 84 [2].
I bisected it and the first bad commit was 587d67fd929a.
Author: Takashi Iwai <tiwai@suse.de>
Date: Fri Mar 15 11:14:42 2024 +0100
ALSA: timer: Fix missing irq-disable at closing
The conversion to guard macro dropped the irq-disablement at closing
mistakenly, which may lead to a race. Fix it.
Fixes: beb45974dd49 ("ALSA: timer: Use guard() for locking")
Reported-by: syzbot+28c1a5a5b041a754b947@syzkaller.appspotmail.com
Closes: http://lore.kernel.org/r/0000000000000b9a510613b0145f@google.com
Message-ID: <20240315101447.18395-1-tiwai@suse.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
To make sure of this I builded kernel at commit 712e14250dd2 with
revert 587d67fd929a and the benchmarking result was returned to best
observed by me.
[1] good results - https://postimg.cc/G4NPHMyk
[2] bad results - https://postimg.cc/1n0D7sYH
I attached here my build .config and kernel log.
Is it possible to find a better approach than 587d67fd929a?
--
Best Regards,
Mike Gavrilov.
[-- Attachment #2: .config.zip --]
[-- Type: application/zip, Size: 66041 bytes --]
[-- Attachment #3: 6.9.0-rc1-test-rev-587d67fd929ad89801bcc429675bda90d53f6592.zip --]
[-- Type: application/zip, Size: 57417 bytes --]
next reply other threads:[~2024-03-31 20:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 20:21 Mikhail Gavrilov [this message]
2024-04-01 7:07 ` regression/bisected/6.9 commit 587d67fd929ad89801bcc429675bda90d53f6592 decrease 30% of gaming performance Takashi Iwai
2024-04-01 11:07 ` Mikhail Gavrilov
2024-04-01 11:41 ` Takashi Iwai
2024-04-01 13:49 ` Mikhail Gavrilov
2024-04-01 14:48 ` Takashi Iwai
2024-04-01 16:50 ` Mikhail Gavrilov
2024-04-01 19:29 ` mikhail.v.gavrilov
2024-04-18 6:22 ` Mikhail Gavrilov
2024-04-24 13:21 ` Mikhail Gavrilov
2024-04-24 13:33 ` Takashi Iwai
2024-04-24 13:42 ` Takashi Iwai
2024-04-29 23:00 ` Mikhail Gavrilov
2024-04-30 5:51 ` Takashi Iwai
2024-04-30 10:54 ` Mikhail Gavrilov
2024-04-30 12:12 ` Takashi Iwai
2024-04-30 14:42 ` Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABXGCsNmEtrN9DK-XmESaPm_1xpXm8A+juE+44Jf6AK5JE0+TQ@mail.gmail.com \
--to=mikhail.v.gavrilov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).