From: John Hubbard <jhubbard@nvidia.com>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Shuah Khan <shuah@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Ivan Orlov <ivan.orlov0322@gmail.com>,
linux-sound@vger.kernel.org,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree()
Date: Mon, 6 May 2024 10:25:34 -0700 [thread overview]
Message-ID: <9cb43d83-466d-471c-a101-b2394b281f0c@nvidia.com> (raw)
In-Reply-To: <ZjjsybLA3VyY0r_N@finisterre.sirena.org.uk>
On 5/6/24 7:44 AM, Mark Brown wrote:
> On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote:
>> Jaroslav Kysela wrote:
>
>>> This function is nice for debugging. I'd prefer to keep it with the fix.
>
>> I'm find in either way; just submit a fix patch, then.
>
> The fix was already submitted as v1, I noticed that the function was
> unused in review.
It's generally considered a best practice to delete unused code. If
there is something you especially like for upcoming code, you still
have git history, and even a lore.kernel.org link, to bookmark it.
So I'd recommend going with v2, but of course it's your call! :)
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2024-05-06 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 21:08 [PATCH v2] selftests/alsa: missing a return value in unused dump_config_tree() John Hubbard
2024-05-06 1:04 ` Mark Brown
2024-05-06 7:19 ` Takashi Iwai
2024-05-06 7:27 ` Jaroslav Kysela
2024-05-06 7:45 ` Takashi Iwai
2024-05-06 14:44 ` Mark Brown
2024-05-06 17:25 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cb43d83-466d-471c-a101-b2394b281f0c@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=broonie@kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).