From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "James Schulman" <james.schulman@cirrus.com>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Banajit Goswami" <bgoswami@quicinc.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v2 0/4] ASoC: qcom: x1e80100: Correct channel mapping
Date: Wed, 08 May 2024 10:16:26 +0200 [thread overview]
Message-ID: <20240508-asoc-x1e80100-4-channel-mapping-v2-0-ccef9a66a572@linaro.org> (raw)
Hi,
First patch is a build dependency.
Changes in v2:
- Re-work most of the idea according to Srini comments: set channel
mapping for backend DAIs, not frontend.
- Patch #1: no changes
- Patch #2 is entirely replaced - now channel mapping is implemented in
q6apm-lpass-dais.
- Patch #3: rework to new approach, but most of the code stays.
- Patch #4: rework significantly, because only backend DAIs is now
affected.
- Link to v1: https://lore.kernel.org/r/20240507-asoc-x1e80100-4-channel-mapping-v1-0-b12c13e0a55d@linaro.org
Description
===========
X1E80100 CRD is the first board, which comes with four speakers, so we
still keep fixing and adding missing pieces.
The board has speaker arranged as left front+back and then right
front+back. Using default channel mapping causes front right speaker to
play left back stream.
Adjust the channel maps for frontend DAIs to fix stereo and four-channel
playback.
Best regards,
Krzysztof
---
Krzysztof Kozlowski (4):
ASoC: Constify channel mapping array arguments in set_channel_map()
ASoC: qcom: q6apm-lpass-dais: Implement proper channel mapping
ASoC: qcom: qdsp6: Set channel mapping instead of fixed defaults
ASoC: qcom: x1e80100: Correct channel mapping
include/sound/cs35l41.h | 4 ++--
include/sound/soc-dai.h | 8 ++++----
sound/soc/codecs/adau7118.c | 6 ++++--
sound/soc/codecs/cs35l41-lib.c | 4 ++--
sound/soc/codecs/cs35l41.c | 3 ++-
sound/soc/codecs/max98504.c | 6 ++++--
sound/soc/codecs/wcd9335.c | 6 ++++--
sound/soc/codecs/wcd934x.c | 6 ++++--
sound/soc/qcom/qdsp6/audioreach.c | 30 +++++++-----------------------
sound/soc/qcom/qdsp6/audioreach.h | 2 +-
sound/soc/qcom/qdsp6/q6afe-dai.c | 16 ++++++++++------
sound/soc/qcom/qdsp6/q6apm-dai.c | 2 ++
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 21 +++++++++++++--------
sound/soc/qcom/x1e80100.c | 18 ++++++++++++++++++
sound/soc/soc-dai.c | 4 ++--
15 files changed, 79 insertions(+), 57 deletions(-)
---
base-commit: 2b84edefcad14934796fad37b16512b6a2ca467e
change-id: 20240507-asoc-x1e80100-4-channel-mapping-ea5f02b9e678
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
next reply other threads:[~2024-05-08 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 8:16 Krzysztof Kozlowski [this message]
2024-05-08 8:16 ` [PATCH v2 1/4] ASoC: Constify channel mapping array arguments in set_channel_map() Krzysztof Kozlowski
2024-05-08 8:25 ` Krzysztof Kozlowski
2024-05-08 8:16 ` [PATCH v2 2/4] ASoC: qcom: q6apm-lpass-dais: Implement proper channel mapping Krzysztof Kozlowski
2024-05-08 8:16 ` [PATCH v2 3/4] ASoC: qcom: qdsp6: Set channel mapping instead of fixed defaults Krzysztof Kozlowski
2024-05-08 8:16 ` [PATCH v2 4/4] ASoC: qcom: x1e80100: Correct channel mapping Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508-asoc-x1e80100-4-channel-mapping-v2-0-ccef9a66a572@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).