linux-sound.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allen Ballway <ballway@chromium.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Brady Norander" <bradynorander@gmail.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Allen Ballway" <ballway@chromium.org>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-sound@vger.kernel.org,
	"Mark Hasemeyer" <markhas@chromium.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Cezary Rojewski" <cezary.rojewski@intel.com>
Subject: [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection
Date: Tue, 30 Apr 2024 21:28:42 +0000	[thread overview]
Message-ID: <20240430212838.1.I77b0636d5df17c275042fd66cfa028de8ad43532@changeid> (raw)

This device has an audio card which is quirked for force SOF use but the
device does not support SOF so the card is not usable and audio can't
play through the HDMI output.

Add another quirk detection that matches the Azulle Access 4 in the DMI
info.

Signed-off-by: Allen Ballway <ballway@chromium.org>
---

 sound/hda/intel-dsp-config.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c
index 6a384b922e4fa..cf4e25d031d56 100644
--- a/sound/hda/intel-dsp-config.c
+++ b/sound/hda/intel-dsp-config.c
@@ -142,7 +142,9 @@ static const struct config_entry config_table[] = {

 /*
  * Geminilake uses legacy HDAudio driver except for Google
- * Chromebooks and devices based on the ES8336 codec
+ * Chromebooks and devices based on the ES8336 codec. The Azulle Access 4
+ * uses the same audio card but does not support ES8336 and should use
+ * the legacy HDAudio driver.
  */
 /* Geminilake */
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
@@ -159,6 +161,20 @@ static const struct config_entry config_table[] = {
 			{}
 		}
 	},
+	{
+		.flags = 0,
+		.device = PCI_DEVICE_ID_INTEL_HDA_GML,
+		.dmi_table = (const struct dmi_system_id []) {
+			{
+				.ident = "Azulle Access 4",
+				.matches = {
+					DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Azulle"),
+					DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Access4"),
+				}
+			},
+		{}
+		}
+	},
 	{
 		.flags = FLAG_SOF,
 		.device = PCI_DEVICE_ID_INTEL_HDA_GML,
--
2.45.0.rc0.197.gbae5840b3b-goog


             reply	other threads:[~2024-04-30 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 21:28 Allen Ballway [this message]
2024-04-30 21:46 ` [PATCH] ALSA: hda: intel-dsp-config: Fix Azulle Access 4 quirk detection Pierre-Louis Bossart
2024-05-06 16:39   ` Allen Ballway
2024-05-06 18:02     ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430212838.1.I77b0636d5df17c275042fd66cfa028de8ad43532@changeid \
    --to=ballway@chromium.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bradynorander@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=markhas@chromium.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).