Re: [PATCH] ARC: avoid unwanted gcc optimizations in atomic operations

From: Vineet Gupta <vgupta@kernel.org>
To: Pavel.Kozlov@synopsys.com, linux-snps-arc@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, vgupta@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARC: avoid unwanted gcc optimizations in atomic operations
Date: Tue, 15 Aug 2023 09:12:48 -0700	[thread overview]
Message-ID: <ed79681e-ecd1-3129-5ad1-2965e2cd42b5@kernel.org> (raw)
In-Reply-To: <20230815151136.2220588-1-kozlov@synopsys.com>

On 8/15/23 08:11, Pavel.Kozlov@synopsys.com wrote:
> From: Pavel Kozlov<pavel.kozlov@synopsys.com>
>
> Notify a compiler about write operations and prevent unwanted
> optimizations. Add the "memory" clobber to the clobber list.
>
> An obvious problem with unwanted compiler optimizations appeared after
> the cpumask optimization commit 596ff4a09b89 ("cpumask: re-introduce
> constant-sized cpumask optimizations").
>
> After this commit the SMP kernels for ARC no longer loads because of
> failed assert in the percpu allocator initialization routine:
>
> percpu: BUG: failure at mm/percpu.c:2981/pcpu_build_alloc_info()!
>
> The write operation performed by the scond instruction in the atomic
> inline asm code is not properly passed to the compiler. The compiler
> cannot correctly optimize a nested loop that runs through the cpumask
> in the pcpu_build_alloc_info() function.
>
> Add the "memory" clobber to fix this.
>
> Link:https://github.com/foss-for-synopsys-dwc-arc-processors/linux/issues/135
> Cc:<stable@vger.kernel.org>  # v6.3+
> Signed-off-by: Pavel Kozlov<pavel.kozlov@synopsys.com>

Acked-by: Vineet Gupta <vgupta@kernel.org>

Fixes: b64be6836993c431e ("ARC: atomics: implement relaxed variants")

Before that commit, atomic ops could elide memory clobber because the 
trailing smp_mb() did that anyways.
However after that commit, the smp_mb() was optional for relaxed 
variants and thus needs clobber.

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc