From: Alexandre Ghiti <alex@ghiti.fr>
To: "Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
"Vineet Gupta" <vgupta@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Michal Simek" <monstr@monstr.eu>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Helge Deller" <deller@gmx.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Rich Felker" <dalias@libc.org>,
"David S . Miller" <davem@davemloft.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"Chris Zankel" <chris@zankel.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org, "Björn Töpel" <bjorn@kernel.org>
Subject: Re: [PATCH v4 00/24] Remove COMMAND_LINE_SIZE from uapi
Date: Thu, 2 Mar 2023 13:38:45 +0100 [thread overview]
Message-ID: <6b206e38-2e2e-0236-1b7d-96a537d0038e@ghiti.fr> (raw)
In-Reply-To: <040104fc-81b7-fd45-b268-111e39f2927f@ghiti.fr>
On 3/2/23 11:06, Alexandre Ghiti wrote:
> Hi Arnd,
>
> On 3/2/23 10:35, Alexandre Ghiti wrote:
>> This all came up in the context of increasing COMMAND_LINE_SIZE in the
>> RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the
>> maximum length of /proc/cmdline and userspace could staticly rely on
>> that to be correct.
>>
>> Usually I wouldn't mess around with changing this sort of thing, but
>> PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE
>> to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE
>> increasing, but they're from before the UAPI split so I'm not quite sure
>> what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from
>> asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel
>> boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"),
>> and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from
>> asm-generic/setup.h.").
>>
>> It seems to me like COMMAND_LINE_SIZE really just shouldn't have been
>> part of the uapi to begin with, and userspace should be able to handle
>> /proc/cmdline of whatever length it turns out to be. I don't see any
>> references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google
>> search, but that's not really enough to consider it unused on my end.
>>
>> This issue was already considered in s390 and they reached the same
>> conclusion in commit 622021cd6c56 ("s390: make command line
>> configurable").
>>
>> The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really
>> shouldn't be part of uapi, so this now touches all the ports. I've
>> tried to split this all out and leave it bisectable, but I haven't
>> tested it all that aggressively.
>>
>> Changes since v3
>> <https://lore.kernel.org/all/20230214074925.228106-1-alexghiti@rivosinc.com/>:
>> * Added RB/AB
>> * Added a mention to commit 622021cd6c56 ("s390: make command line
>> configurable") in the cover letter
>>
>> Changes since v2
>> <https://lore.kernel.org/all/20221211061358.28035-1-palmer@rivosinc.com/>:
>> * Fix sh, csky and ia64 builds, as reported by kernel test robot
>>
>> Changes since v1
>> <https://lore.kernel.org/all/20210423025545.313965-1-palmer@dabbelt.com/>:
>> * Touches every arch.
>>
>> base-commit-tag: next-20230207
>>
>> Palmer Dabbelt (24):
>> alpha: Remove COMMAND_LINE_SIZE from uapi
>> arm64: Remove COMMAND_LINE_SIZE from uapi
>> arm: Remove COMMAND_LINE_SIZE from uapi
>> ia64: Remove COMMAND_LINE_SIZE from uapi
>> m68k: Remove COMMAND_LINE_SIZE from uapi
>> microblaze: Remove COMMAND_LINE_SIZE from uapi
>> mips: Remove COMMAND_LINE_SIZE from uapi
>> parisc: Remove COMMAND_LINE_SIZE from uapi
>> powerpc: Remove COMMAND_LINE_SIZE from uapi
>> sparc: Remove COMMAND_LINE_SIZE from uapi
>> xtensa: Remove COMMAND_LINE_SIZE from uapi
>> asm-generic: Remove COMMAND_LINE_SIZE from uapi
>> alpha: Remove empty <uapi/asm/setup.h>
>> arc: Remove empty <uapi/asm/setup.h>
>> m68k: Remove empty <uapi/asm/setup.h>
>> arm64: Remove empty <uapi/asm/setup.h>
>> microblaze: Remove empty <uapi/asm/setup.h>
>> sparc: Remove empty <uapi/asm/setup.h>
>> parisc: Remove empty <uapi/asm/setup.h>
>> x86: Remove empty <uapi/asm/setup.h>
>> xtensa: Remove empty <uapi/asm/setup.h>
>> powerpc: Remove empty <uapi/asm/setup.h>
>> mips: Remove empty <uapi/asm/setup.h>
>> s390: Remove empty <uapi/asm/setup.h>
>>
>> .../admin-guide/kernel-parameters.rst | 2 +-
>> arch/alpha/include/asm/setup.h | 4 +--
>> arch/alpha/include/uapi/asm/setup.h | 7 -----
>> arch/arc/include/asm/setup.h | 1 -
>> arch/arc/include/uapi/asm/setup.h | 6 -----
>> arch/arm/include/asm/setup.h | 1 +
>> arch/arm/include/uapi/asm/setup.h | 2 --
>> arch/arm64/include/asm/setup.h | 3 ++-
>> arch/arm64/include/uapi/asm/setup.h | 27 -------------------
>> arch/ia64/include/asm/setup.h | 10 +++++++
>> arch/ia64/include/uapi/asm/setup.h | 6 ++---
>> arch/loongarch/include/asm/setup.h | 2 +-
>> arch/m68k/include/asm/setup.h | 3 +--
>> arch/m68k/include/uapi/asm/setup.h | 17 ------------
>> arch/microblaze/include/asm/setup.h | 2 +-
>> arch/microblaze/include/uapi/asm/setup.h | 20 --------------
>> arch/mips/include/asm/setup.h | 3 ++-
>> arch/mips/include/uapi/asm/setup.h | 8 ------
>> arch/parisc/include/{uapi => }/asm/setup.h | 0
>> arch/powerpc/include/asm/setup.h | 2 +-
>> arch/powerpc/include/uapi/asm/setup.h | 7 -----
>> arch/s390/include/asm/setup.h | 1 -
>> arch/s390/include/uapi/asm/setup.h | 1 -
>> arch/sh/include/asm/setup.h | 2 +-
>> arch/sparc/include/asm/setup.h | 6 ++++-
>> arch/sparc/include/uapi/asm/setup.h | 16 -----------
>> arch/x86/include/asm/setup.h | 2 --
>> arch/x86/include/uapi/asm/setup.h | 1 -
>> arch/xtensa/include/{uapi => }/asm/setup.h | 0
>> include/asm-generic/Kbuild | 1 +
>> include/{uapi => }/asm-generic/setup.h | 0
>> include/uapi/asm-generic/Kbuild | 1 -
>> 32 files changed, 31 insertions(+), 133 deletions(-)
>> delete mode 100644 arch/alpha/include/uapi/asm/setup.h
>> delete mode 100644 arch/arc/include/uapi/asm/setup.h
>> delete mode 100644 arch/arm64/include/uapi/asm/setup.h
>> create mode 100644 arch/ia64/include/asm/setup.h
>> delete mode 100644 arch/m68k/include/uapi/asm/setup.h
>> delete mode 100644 arch/microblaze/include/uapi/asm/setup.h
>> delete mode 100644 arch/mips/include/uapi/asm/setup.h
>> rename arch/parisc/include/{uapi => }/asm/setup.h (100%)
>> delete mode 100644 arch/powerpc/include/uapi/asm/setup.h
>> delete mode 100644 arch/s390/include/uapi/asm/setup.h
>> delete mode 100644 arch/sparc/include/uapi/asm/setup.h
>> delete mode 100644 arch/x86/include/uapi/asm/setup.h
>> rename arch/xtensa/include/{uapi => }/asm/setup.h (100%)
>> rename include/{uapi => }/asm-generic/setup.h (100%)
>>
> Björn noticed that I should also remove the command line size for
> riscv since it was picked up in 6.3 by Palmer...I send a v6 right now,
> sorry about that.
>
> Alex
>
Hmmm when implementing the riscv patch, I noticed that the patches that
introduce a new include/asm/setup.h file add the following SPDX header:
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
To me we should not add "WITH Linux-syscall-note" as this header is not
part of the user visible headers: any opinion before I send the v5?
Thanks,
Alex
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2023-03-02 13:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 9:35 [PATCH v4 00/24] Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 01/24] alpha: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 02/24] arm64: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 03/24] arm: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 04/24] ia64: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 05/24] m68k: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 06/24] microblaze: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 07/24] mips: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 08/24] parisc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 09/24] powerpc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 10/24] sparc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 11/24] xtensa: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 12/24] asm-generic: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 13/24] alpha: Remove empty <uapi/asm/setup.h> Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 14/24] arc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 15/24] m68k: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 16/24] arm64: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 17/24] microblaze: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 18/24] sparc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 19/24] parisc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 20/24] x86: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 21/24] xtensa: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 22/24] powerpc: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 23/24] mips: " Alexandre Ghiti
2023-03-02 9:35 ` [PATCH v4 24/24] s390: " Alexandre Ghiti
2023-03-02 9:47 ` [PATCH v4 00/24] Remove COMMAND_LINE_SIZE from uapi Geert Uytterhoeven
2023-03-02 10:09 ` Alexandre Ghiti
2023-03-02 10:44 ` Geert Uytterhoeven
2023-03-02 10:45 ` Alexandre Ghiti
2023-03-02 10:06 ` Alexandre Ghiti
2023-03-02 12:38 ` Alexandre Ghiti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b206e38-2e2e-0236-1b7d-96a537d0038e@ghiti.fr \
--to=alex@ghiti.fr \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bjorn@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard.henderson@linaro.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).