From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
vgupta@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-snps-arc@lists.infradead.org, skhan@linuxfoundation.org,
javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] dt-bindings: pct: Convert to dtschema
Date: Fri, 8 Mar 2024 09:05:06 +0100 [thread overview]
Message-ID: <53987b65-32f8-433d-beac-007499f0b08b@linaro.org> (raw)
In-Reply-To: <20240308021842.1975-1-dorine.a.tipo@gmail.com>
On 08/03/2024 03:18, Dorine Tipo wrote:
> convert the PCT Arc Performance Counter bindings to DT schema
There is no conversion here!
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> .../devicetree/bindings/arc/pct.yaml | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arc/pct.yaml
>
> diff --git a/Documentation/devicetree/bindings/arc/pct.yaml b/Documentation/devicetree/bindings/arc/pct.yaml
> new file mode 100644
> index 000000000000..1f97a7c21b77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arc/pct.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pct.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARC Performance Counters
> +
> +maintainers:
> + - Vineet Gupta <vgupta@kernel.org>
> + - Rob Herring <robh+dt@kernel.org>
> + - Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
No, neither me nor Rob have anything to do with Arc. Please choose
someone from the ARC maintainers, if there is no specific device maintainer.
> +
> +description: |
> + The ARC700 can be configured with a pipeline performance monitor for counting
> + CPU and cache events like cache misses and hits. Like conventional PCT there
> + are 100+ hardware conditions dynamically mapped to up to 32 counters
> +
> +properties:
> + compatible:
> + const: "snps,arc700-pct"
Drop quotes. I have doubts that you tested it.
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
This must be additionalProperties instead. See example schema.
> +
> +examples:
> + - |
> + pmu {
> + compatible = "snps,arc700-pct";
NAK, test your patches.
>
Best regards,
Krzysztof
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
prev parent reply other threads:[~2024-03-08 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 2:18 [PATCH] dt-bindings: pct: Convert to dtschema Dorine Tipo
2024-03-08 3:38 ` Rob Herring
2024-03-08 8:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53987b65-32f8-433d-beac-007499f0b08b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dorine.a.tipo@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).