From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Artur Rojek <contact@artur-rojek.eu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: hd64461: Make setup_hd64461 static
Date: Wed, 14 Feb 2024 13:56:31 +0100 [thread overview]
Message-ID: <e411e5ff09db2eabb2ddd2a6f7bd0db67b76ff7a.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20240211193451.106795-1-contact@artur-rojek.eu>
On Sun, 2024-02-11 at 20:34 +0100, Artur Rojek wrote:
> Enforce internal linkage for setup_hd64461.
>
> This fixes the following error:
> arch/sh/cchips/hd6446x/hd64461.c:75:12: error: no previous prototype for 'setup_hd64461' [-Werror=missing-prototypes]
>
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> arch/sh/cchips/hd6446x/hd64461.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/cchips/hd6446x/hd64461.c b/arch/sh/cchips/hd6446x/hd64461.c
> index f3fba967445a..81764882d87d 100644
> --- a/arch/sh/cchips/hd6446x/hd64461.c
> +++ b/arch/sh/cchips/hd6446x/hd64461.c
> @@ -72,7 +72,7 @@ static void hd64461_irq_demux(struct irq_desc *desc)
> }
> }
>
> -int __init setup_hd64461(void)
> +static int __init setup_hd64461(void)
> {
> int irq_base, i;
>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
I will merge this patch for 6.9 tonight.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2024-02-14 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 19:34 [PATCH] sh: hd64461: Make setup_hd64461 static Artur Rojek
2024-02-14 12:56 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e411e5ff09db2eabb2ddd2a6f7bd0db67b76ff7a.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=contact@artur-rojek.eu \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).