From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] sh: Fix missing prototypes (part three)
Date: Mon, 13 May 2024 15:30:02 +0200 [thread overview]
Message-ID: <abc8fb59ceb102895320850609c7d6e29aedcf1a.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <cover.1715606232.git.geert+renesas@glider.be>
Hi Geert,
On Mon, 2024-05-13 at 15:20 +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series fixes more "no previous prototype for <foo>" warnings
> when building a kernel for SuperH, namely when building j2_defconfig.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (3):
> sh: of-generic: Add missing #include <asm/clock.h>
> sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING
> sh: setup: Add missing forward declaration for sh_fdt_init()
>
> arch/sh/boards/of-generic.c | 2 ++
> arch/sh/include/asm/setup.h | 1 +
> arch/sh/kernel/smp.c | 2 ++
> 3 files changed, 5 insertions(+)
Thanks a lot for fixing these. I have run into these as well and except
for patch #2 where you found the proper fix, my proposed fixes looked
exactly the same.
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2024-05-13 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 13:20 [PATCH 0/3] sh: Fix missing prototypes (part three) Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 1/3] sh: of-generic: Add missing #include <asm/clock.h> Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 2/3] sh: smp: Protect setup_profiling_timer() by CONFIG_PROFILING Geert Uytterhoeven
2024-05-13 13:20 ` [PATCH 3/3] sh: setup: Add missing forward declaration for sh_fdt_init() Geert Uytterhoeven
2024-05-13 13:30 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc8fb59ceb102895320850609c7d6e29aedcf1a.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).