From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Huy Nguyen" <huy.nguyen.wh@renesas.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"biju.das.au" <biju.das.au@gmail.com>,
"Linux-sh list" <linux-sh@vger.kernel.org>
Subject: RE: [PATCH v2 3/5] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
Date: Thu, 14 Mar 2024 13:09:10 +0000 [thread overview]
Message-ID: <OSAPR01MB1587F2782BAAC8E45C0E21BC86292@OSAPR01MB1587.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWOZdJujd7+Tycn144-fqM7a6bsnJ0+82Ndqk69jTTf+w@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Thursday, March 14, 2024 1:04 PM
> Subject: Re: [PATCH v2 3/5] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
>
> Hi Biju,
>
> On Thu, Mar 14, 2024 at 1:49 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org> On Wed, Mar 13, 2024
> > > at 7:16 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > > From: Huy Nguyen <huy.nguyen.wh@renesas.com> The RZ/G2L family
> > > > SoCs has 10 PIPE buffers compared to 16 pipe buffers on RZ/A2M.
> > > > Update the pipe configuration for RZ/G2L family SoCs and use
> > > > family SoC specific compatible to handle this difference.
> > > >
> > > > Added SoC specific compatible to OF table toavoid ABI breakage
> > > > with old DTB. To optimize memory usage the SoC specific compatible
> > > > will be removed later.
> > > >
> > > > Signed-off-by: Huy Nguyen <huy.nguyen.wh@renesas.com>
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> > > > --- a/drivers/usb/renesas_usbhs/common.c
> > > > +++ b/drivers/usb/renesas_usbhs/common.c
> > > > @@ -640,8 +656,13 @@ static int usbhs_probe(struct platform_device
> > > > *pdev)
>
> > Since [1] is better compared to [2], if SH can work with [1], we can
> > replace [2] with [1], do we have any SH platform to test this?
>
> I don't have an sh7757lcr or ecovec24 to test. But the risk looks low.
>
> So it looks like a good idea to have two patches:
> 1. Improve usbhsc_default_pipe[] for isochronous transfers,
> 2. Fix support for RZ/G2L using the default 10-entry pipe.
>
Agreed. Will send v3 with these changes.
Cheers,
Biju
prev parent reply other threads:[~2024-03-14 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240313181602.156840-1-biju.das.jz@bp.renesas.com>
[not found] ` <20240313181602.156840-4-biju.das.jz@bp.renesas.com>
[not found] ` <CAMuHMdUMEA2d9+H7GwDDLTfeXp2fAyBTt8jpihOzjCEMUuSK-A@mail.gmail.com>
[not found] ` <OSAPR01MB15874373FDCB149EA67D4BD086292@OSAPR01MB1587.jpnprd01.prod.outlook.com>
2024-03-14 13:04 ` [PATCH v2 3/5] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Geert Uytterhoeven
2024-03-14 13:09 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB1587F2782BAAC8E45C0E21BC86292@OSAPR01MB1587.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=biju.das.au@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=huy.nguyen.wh@renesas.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).