From: Geert Uytterhoeven <geert@linux-m68k.org>
To: xuanzhenggang001@208suo.com
Cc: ysato@users.sourceforge.jp, dalias@libc.org,
glaubitz@physik.fu-berlin.de, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'
Date: Wed, 18 Oct 2023 15:53:19 +0200 [thread overview]
Message-ID: <CAMuHMdWLxc7Tu2FNMRiO_LMjM2VSdtmHAiMeWv-+NgxA9+fqeQ@mail.gmail.com> (raw)
In-Reply-To: <7554aadc5afb915ee1065cea56053cb6@208suo.com>
On Sun, Jul 9, 2023 at 2:39 PM <xuanzhenggang001@208suo.com> wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>
> ---
> arch/sh/drivers/heartbeat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
> index 24391b444b28..07f04ed0d517 100644
> --- a/arch/sh/drivers/heartbeat.c
> +++ b/arch/sh/drivers/heartbeat.c
> @@ -30,7 +30,7 @@
> static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };
>
> static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
> - unsigned bit, unsigned int inverted)
> + unsigned int bit, unsigned int inverted)
> {
> unsigned int new;
>
> @@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct
> heartbeat_data *hd,
patch: **** malformed patch at line 19: heartbeat_data *hd,
Please fix your email setup.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2023-10-18 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230709123329.33674-1-denghuilong@cdjrlc.com>
2023-07-09 12:35 ` [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned' xuanzhenggang001
2023-10-18 13:53 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWLxc7Tu2FNMRiO_LMjM2VSdtmHAiMeWv-+NgxA9+fqeQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=xuanzhenggang001@208suo.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).