From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Huy Nguyen" <huy.nguyen.wh@renesas.com>,
"Rob Herring" <robh@kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Biju Das" <biju.das.au@gmail.com>,
"Linux-sh list" <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v4 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
Date: Tue, 19 Mar 2024 09:43:49 +0100 [thread overview]
Message-ID: <CAMuHMdUqgBWmb1ovwDn+Xx0RVLdBCAZnSj48Dse6YPNDx1A6Pg@mail.gmail.com> (raw)
In-Reply-To: <20240318173319.201799-5-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, Mar 18, 2024 at 6:33 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The RZ/G2L family SoCs has 10 pipe buffers compared to 16 pipe buffers on
> RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and use
> family SoC specific compatible to handle this difference.
>
> The pipe configuration of RZ/G2L is same as usbhsc_rzg2l_default_pipe[],
> so select the default pipe configuration for RZ/G2L SoCs by setting
> .has_new_pipe_configs to zero.
>
> Add SoC specific compatible to OF table to avoid ABI breakage with old
> DTB. To optimize memory usage the SoC specific compatible will be removed
> later.
>
> Based on the patch in BSP by Huy Nguyen <huy.nguyen.wh@renesas.com>
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v3->v4:
> * Credit Huy Nguyen's work in the commit message and dropped his name
> from Signed-off-by tag.
> * Selection of usbhsc_rzg2l_default_pipe[] by setting the variable
> has_new_pipe_configs to zero.
> * Updated commit description.
Thanks for the update!
> * Dropped the check 'priv->dparam.pipe_configs' as it is same as
> checking !has_new_pipe_configs.
I disagree: it is used to specify the pipe config through platform
data on non-DT platforms. There don't seem to be any upstream SH
platforms doing that, though.
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -642,7 +658,7 @@ static int usbhs_probe(struct platform_device *pdev)
> if (usbhs_get_dparam(priv, has_new_pipe_configs)) {
> priv->dparam.pipe_configs = usbhsc_new_pipe;
> priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
> - } else if (!priv->dparam.pipe_configs) {
> + } else {
Hence I'd rather drop this check.
> priv->dparam.pipe_configs = usbhsc_default_pipe;
> priv->dparam.pipe_size = ARRAY_SIZE(usbhsc_default_pipe);
> }
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next parent reply other threads:[~2024-03-19 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240318173319.201799-1-biju.das.jz@bp.renesas.com>
[not found] ` <20240318173319.201799-5-biju.das.jz@bp.renesas.com>
2024-03-19 8:43 ` Geert Uytterhoeven [this message]
2024-03-19 9:04 ` [PATCH v4 4/6] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUqgBWmb1ovwDn+Xx0RVLdBCAZnSj48Dse6YPNDx1A6Pg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=huy.nguyen.wh@renesas.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).