From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de
Subject: Re: [RESEND RFC PATCH 03/12] sh: SH4 OF support.
Date: Fri, 15 Sep 2023 18:21:36 +0900 [thread overview]
Message-ID: <87v8cbu6zj.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <CAMuHMdV84_M9QG7DKvrgP-d2+FDh4NXFYPG5zt49hmgmxrAYwg@mail.gmail.com>
On Wed, 13 Sep 2023 21:23:14 +0900,
Geert Uytterhoeven wrote:
>
> Hi Sato-san,
>
> On Thu, Aug 31, 2023 at 5:22 AM Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > - switch generic framework in clock / PCI.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> > --- a/arch/sh/include/asm/io.h
> > +++ b/arch/sh/include/asm/io.h
> > @@ -292,4 +292,14 @@ static inline void iounmap(volatile void __iomem *addr) { }
> > int valid_phys_addr_range(phys_addr_t addr, size_t size);
> > int valid_mmap_phys_addr_range(unsigned long pfn, size_t size);
> >
> > +
> > +#ifdef __KERNEL__
> > +#define PCI_IOBASE 0xfe240000UL
> > +
> > +#define HAVE_ARCH_PIO_SIZE
> > +#define PIO_OFFSET PCI_IOBASE
> > +#define PIO_MASK 0x3ffffUL
> > +#define PIO_RESERVED 0x40000UL
> > +#endif /* __KERNEL__ */
> > +
>
> Since commit b94692e84dccf12d ("sh: add <asm-generic/io.h> including")
> in v6.6-rc1, the new definitions must be inserted higher up, before
> the inclusion of <asm-generic/io.h>, to avoid:
>
> arch/sh/include/asm/io.h:322: warning: "PCI_IOBASE" redefined
> 322 | #define PCI_IOBASE 0xfe240000UL
> |
> include/asm-generic/io.h:527: note: this is the location of the
> previous definition
>
> > #endif /* __ASM_SH_IO_H */
OK.
This has been fixed in the v2 patch.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Yosinori Sato
next prev parent reply other threads:[~2023-09-15 9:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 1:11 [RESEND RFC PATCH 00/12] DeviceTree support for SH7751 based boards Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 01/12] sh: Add OF target boards Yoshinori Sato
2023-09-01 12:22 ` Geert Uytterhoeven
2023-09-01 14:26 ` Geert Uytterhoeven
2023-09-06 8:05 ` Yoshinori Sato
2023-09-06 8:12 ` John Paul Adrian Glaubitz
2023-09-07 3:28 ` Yoshinori Sato
2023-09-07 3:35 ` Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 02/12] sh: Update OF handling Yoshinori Sato
2023-09-01 12:25 ` Geert Uytterhoeven
2023-08-31 1:11 ` [RESEND RFC PATCH 03/12] sh: SH4 OF support Yoshinori Sato
2023-09-01 12:26 ` Geert Uytterhoeven
2023-09-13 12:23 ` Geert Uytterhoeven
2023-09-15 9:21 ` Yoshinori Sato [this message]
2023-08-31 1:11 ` [RESEND RFC PATCH 04/12] clk: SH7750 / 7751 clk driver Yoshinori Sato
2023-09-01 12:26 ` Geert Uytterhoeven
2023-09-07 3:44 ` Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 05/12] drivers/irqchip: Add SH7751 and boards specific irqchip Yoshinori Sato
2023-09-01 12:49 ` Geert Uytterhoeven
2023-08-31 1:11 ` [RESEND RFC PATCH 06/12] drivers/pci: Add SH7751 PCI Host bridge driver Yoshinori Sato
2023-09-01 12:54 ` Geert Uytterhoeven
2023-08-31 1:11 ` [RESEND RFC PATCH 07/12] clocksource: Update sh_tmu of handling Yoshinori Sato
2023-08-31 6:48 ` Krzysztof Kozlowski
2023-09-01 13:01 ` Geert Uytterhoeven
2023-09-01 13:40 ` Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 08/12] mfd/sm501: Add OF properties Yoshinori Sato
2023-08-31 6:51 ` Krzysztof Kozlowski
2023-09-01 13:09 ` Geert Uytterhoeven
2023-08-31 1:11 ` [RESEND RFC PATCH 09/12] of: FDT vaddr support for SH Yoshinori Sato
2023-08-31 6:48 ` Krzysztof Kozlowski
2023-09-01 13:11 ` Geert Uytterhoeven
2023-09-01 13:33 ` Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 10/12] serial/sh-sci: Fix earlyprintk / earlycon Yoshinori Sato
2023-09-01 13:26 ` Geert Uytterhoeven
2023-09-06 7:27 ` Yoshinori Sato
2023-08-31 1:11 ` [RESEND RFC PATCH 11/12] sh: target dts Yoshinori Sato
2023-09-01 14:23 ` Geert Uytterhoeven
2023-08-31 1:11 ` [RESEND RFC PATCH 12/12] sh: OF defconfig Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8cbu6zj.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).