From: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
To: <ysato@users.sourceforge.jp>, <dalias@libc.org>,
<glaubitz@physik.fu-berlin.de>
Cc: <akpm@linux-foundation.org>, <linux-sh@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<kernel@quicinc.com>,
Oreoluwa Babatunde <quic_obabatun@quicinc.com>,
Rob Herring <robh@kernel.org>
Subject: [PATCH v2] sh: Call paging_init() earlier in the init sequence
Date: Tue, 23 Apr 2024 16:31:50 -0700 [thread overview]
Message-ID: <20240423233150.74302-1-quic_obabatun@quicinc.com> (raw)
The unflatten_device_tree() function contains a call to
memblock_alloc(). This is a problem because this allocation is done
before any of the reserved memory is set aside in paging_init().
This means that there is a possibility for memblock to allocate from
any of the memory regions that are supposed to be set aside as reserved.
Hence, move the call to paging_init() to be earlier in the init
sequence so that the reserved memory regions are set aside before any
allocations are done using memblock.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
---
v2:
- Added Rob Herrings Reviewed-by.
- cc Andrew Morton to assist with merging this for sh architecture.
Similar change made for loongarch and openrisc in v1 have already
been merged.
v1:
https://lore.kernel.org/all/1707524971-146908-4-git-send-email-quic_obabatun@quicinc.com/
arch/sh/kernel/setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c
index 620e5cf8ae1e..98c8473e130d 100644
--- a/arch/sh/kernel/setup.c
+++ b/arch/sh/kernel/setup.c
@@ -322,6 +322,8 @@ void __init setup_arch(char **cmdline_p)
/* Let earlyprintk output early console messages */
sh_early_platform_driver_probe("earlyprintk", 1, 1);
+ paging_init();
+
#ifdef CONFIG_OF_EARLY_FLATTREE
#ifdef CONFIG_USE_BUILTIN_DTB
unflatten_and_copy_device_tree();
@@ -330,8 +332,6 @@ void __init setup_arch(char **cmdline_p)
#endif
#endif
- paging_init();
-
/* Perform the machine specific initialisation */
if (likely(sh_mv.mv_setup))
sh_mv.mv_setup(cmdline_p);
--
2.34.1
next reply other threads:[~2024-04-23 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 23:31 Oreoluwa Babatunde [this message]
2024-04-24 4:47 ` [PATCH v2] sh: Call paging_init() earlier in the init sequence John Paul Adrian Glaubitz
2024-04-24 8:45 ` Markus Elfring
2024-04-24 10:24 ` John Paul Adrian Glaubitz
2024-04-24 11:06 ` [v2] " Markus Elfring
2024-04-29 9:03 ` [PATCH v2] " John Paul Adrian Glaubitz
2024-04-29 16:28 ` Oreoluwa Babatunde
2024-04-29 17:26 ` John Paul Adrian Glaubitz
2024-04-29 17:54 ` Oreoluwa Babatunde
2024-05-01 17:18 ` John Paul Adrian Glaubitz
2024-05-02 10:29 ` John Paul Adrian Glaubitz
2024-05-07 21:42 ` Oreoluwa Babatunde
2024-05-07 22:41 ` John Paul Adrian Glaubitz
2024-05-20 18:03 ` Oreoluwa Babatunde
2024-05-20 18:24 ` John Paul Adrian Glaubitz
2024-05-20 18:49 ` Oreoluwa Babatunde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423233150.74302-1-quic_obabatun@quicinc.com \
--to=quic_obabatun@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kernel@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).