From: "Huang, Kai" <kai.huang@intel.com>
To: "jarkko@kernel.org" <jarkko@kernel.org>
Cc: "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"Dhanraj, Vijay" <vijay.dhanraj@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] x86/sgx: Do not fail on incomplete sanitization on premature stop of ksgxd
Date: Mon, 5 Sep 2022 11:32:40 +0000 [thread overview]
Message-ID: <f2d51953686293d23fe1b0782f57b5e51ea84d5b.camel@intel.com> (raw)
In-Reply-To: <YxXFGLSmRri2T1yb@kernel.org>
On Mon, 2022-09-05 at 12:44 +0300, jarkko@kernel.org wrote:
> On Mon, Sep 05, 2022 at 07:50:33AM +0000, Huang, Kai wrote:
> > On Sat, 2022-09-03 at 13:26 +0300, Jarkko Sakkinen wrote:
> > > > static int ksgxd(void *p)
> > > > {
> > > > + unsigned long left_dirty;
> > > > +
> > > > set_freezable();
> > > >
> > > > /*
> > > > * Sanitize pages in order to recover from kexec(). The 2nd pass is
> > > > * required for SECS pages, whose child pages blocked EREMOVE.
> > > > */
> > > > - __sgx_sanitize_pages(&sgx_dirty_page_list);
> > > > - __sgx_sanitize_pages(&sgx_dirty_page_list);
> > > > + left_dirty = __sgx_sanitize_pages(&sgx_dirty_page_list);
> > > > + pr_debug("%ld unsanitized pages\n", left_dirty);
> > > %lu
> > >
> >
> > I assume the intention is to print out the unsanitized SECS pages, but what is
> > the value of printing it? To me it doesn't provide any useful information, even
> > for debug.
>
> How do you measure "useful"?
>
> If for some reason there were unsanitized pages, I would at least
> want to know where it ended on the first value.
Using pr_debug() means it's for debugging the driver, but to me it doesn't help
on debugging the driver, so it is not useful.
Anyway, I will stop argue here.
--
Thanks,
-Kai
next prev parent reply other threads:[~2022-09-05 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 6:01 [PATCH 0/2] x86/sgx: Fixes for v6.0 Jarkko Sakkinen
2022-09-03 6:01 ` [PATCH 1/2] x86/sgx: Do not fail on incomplete sanitization on premature stop of ksgxd Jarkko Sakkinen
2022-09-03 10:26 ` Jarkko Sakkinen
2022-09-05 7:50 ` Huang, Kai
2022-09-05 9:44 ` jarkko
2022-09-05 10:17 ` jarkko
2022-09-05 11:32 ` Huang, Kai [this message]
2022-09-03 6:01 ` [PATCH 2/2] x86/sgx: Handle VA page allocation failure for EAUG on PF Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2d51953686293d23fe1b0782f57b5e51ea84d5b.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=reinette.chatre@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vijay.dhanraj@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).