From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Zhang, Cathy" <cathy.zhang@intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>
Subject: Re: [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section
Date: Wed, 06 Apr 2022 09:34:02 +0300 [thread overview]
Message-ID: <b05d36962c6eaf7968329f833c73849700298bbc.camel@kernel.org> (raw)
In-Reply-To: <77a9e893ffe54dca9685b97cdf79b078@intel.com>
On Wed, 2022-04-06 at 04:00 +0000, Zhang, Cathy wrote:
>
>
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > Sent: Sunday, April 3, 2022 6:15 PM
> > To: Zhang, Cathy <cathy.zhang@intel.com>
> > Cc: linux-sgx@vger.kernel.org; x86@kernel.org; Chatre, Reinette
> > <reinette.chatre@intel.com>; Hansen, Dave <dave.hansen@intel.com>; Raj,
> > Ashok <ashok.raj@intel.com>
> > Subject: Re: [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section
> >
> > On Fri, Apr 01, 2022 at 10:24:04PM +0800, Cathy Zhang wrote:
> > > For SGX CPUSVN update process will check all EPC pages in each section
> > > to ensure they will be marked as unused, it requires to know the size
> > > of each EPC section to end the loop.
> >
> > Why is the size required to end the loop? It's missing.
>
> How about re-write as follows:
>
> SGX CPUSVN update process should check all EPC pages to ensure they
> will be marked as unused. For EPC pages are stored in EPC sections,
> it's required to save the size of each section, as the indicator for
> the end of each section's traversing.
Sounds good to me.
BR, Jarkko
next prev parent reply other threads:[~2022-04-06 10:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:23 [RFC PATCH v3 00/10] Support microcode updates affecting SGX Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 01/10] x86/sgx: Introduce mechanism to prevent new initializations of EPC pages Cathy Zhang
2022-04-03 8:13 ` Jarkko Sakkinen
2022-04-06 3:31 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 02/10] x86/sgx: Provide VA page non-NULL owner Cathy Zhang
2022-04-03 8:29 ` Jarkko Sakkinen
2022-04-01 14:24 ` [RFC PATCH v3 03/10] x86/sgx: Save enclave pointer for VA page Cathy Zhang
2022-04-03 10:08 ` Jarkko Sakkinen
2022-04-06 3:31 ` Zhang, Cathy
2022-04-06 6:33 ` Jarkko Sakkinen
2022-04-01 14:24 ` [RFC PATCH v3 04/10] x86/sgx: Keep record for SGX VA and Guest page type Cathy Zhang
2022-04-03 10:11 ` Jarkko Sakkinen
2022-04-06 3:38 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 05/10] x86/sgx: Save the size of each EPC section Cathy Zhang
2022-04-03 10:14 ` Jarkko Sakkinen
2022-04-06 4:00 ` Zhang, Cathy
2022-04-06 6:34 ` Jarkko Sakkinen [this message]
2022-04-01 14:24 ` [RFC PATCH v3 06/10] x86/sgx: Forced EPC page zapping for EUPDATESVN Cathy Zhang
2022-04-03 10:20 ` Jarkko Sakkinen
2022-04-06 4:21 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 07/10] x86/sgx: Define error codes for ENCLS[EUPDATESVN] Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 08/10] x86/sgx: Implement ENCLS[EUPDATESVN] Cathy Zhang
2022-04-01 14:24 ` [RFC PATCH v3 09/10] x86/cpu: Call ENCLS[EUPDATESVN] procedure in microcode update Cathy Zhang
2022-04-01 14:29 ` Borislav Petkov
2022-04-02 2:54 ` Zhang, Cathy
2022-04-01 15:42 ` Dave Hansen
2022-04-02 3:02 ` Zhang, Cathy
2022-04-01 14:24 ` [RFC PATCH v3 10/10] x86/sgx: Call ENCLS[EUPDATESVN] during SGX initialization Cathy Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b05d36962c6eaf7968329f833c73849700298bbc.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=ashok.raj@intel.com \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).