From: Jarkko Sakkinen <jarkko@kernel.org>
To: Zhiquan Li <zhiquan1.li@intel.com>
Cc: linux-sgx@vger.kernel.org, tony.luck@intel.com,
dave.hansen@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
seanjc@google.com, kai.huang@intel.com, fan.du@intel.com,
cathy.zhang@intel.com
Subject: Re: [PATCH v8 3/3] x86/sgx: Fine grained SGX MCA behavior for virtualization
Date: Tue, 20 Sep 2022 07:52:00 +0300 [thread overview]
Message-ID: <YylG8MnvwjUY6N5L@kernel.org> (raw)
In-Reply-To: <20220913145330.2998212-4-zhiquan1.li@intel.com>
On Tue, Sep 13, 2022 at 10:53:30PM +0800, Zhiquan Li wrote:
> Today, if a guest accesses an SGX EPC page with memory failure,
> the kernel behavior will kill the entire guest. This blast
> radius is too large. It would be idea to kill only the SGX
> application inside the guest.
>
> To fix this, send a SIGBUS to host userspace (like QEMU) which can
> follow up by injecting a #MC to the guest.
>
> SGX virtual EPC driver doesn't explicitly prevent virtual EPC instance
> being shared by multiple VMs via fork(). However KVM doesn't support
> running a VM across multiple mm structures, and the de facto userspace
> hypervisor (Qemu) doesn't use fork() to create a new VM, so in practice
> this should not happen.
>
> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>
> Acked-by: Kai Huang <kai.huang@intel.com>
> Link: https://lore.kernel.org/linux-sgx/443cb425-009c-2784-56f4-5e707122de76@intel.com/T/#m1d1f4098f4fad78034e8706a60e4d79c119db407
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
ditto
BR, Jarkko
prev parent reply other threads:[~2022-09-20 4:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 14:53 [PATCH v8 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-09-13 14:53 ` [PATCH v8 1/3] x86/sgx: Rename the owner field of struct sgx_epc_page as encl_owner Zhiquan Li
2022-09-13 14:53 ` [PATCH v8 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case Zhiquan Li
2022-09-13 16:40 ` Huang, Kai
2022-09-14 0:29 ` Zhiquan Li
2022-09-14 15:46 ` Haitao Huang
2022-09-15 2:22 ` Zhiquan Li
2022-09-15 20:00 ` Haitao Huang
2022-09-20 4:51 ` Jarkko Sakkinen
2022-09-13 14:53 ` [PATCH v8 3/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
2022-09-20 4:52 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YylG8MnvwjUY6N5L@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).