From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-sgx@vger.kernel.org,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
reinette.chatre@intel.com,
Nathaniel McCallum <nathaniel@profian.com>, "Christopherson,,
Sean" <seanjc@google.com>
Subject: Re: VMA's not getting merged
Date: Mon, 6 Jun 2022 14:40:20 +0300 [thread overview]
Message-ID: <Yp3npNLu6Blaphxk@iki.fi> (raw)
In-Reply-To: <Yp2q68qYtdpR+Z+T@iki.fi>
On Mon, Jun 06, 2022 at 10:21:15AM +0300, Jarkko Sakkinen wrote:
> Dave: so my question is this: can VM_SPECIAL check be
> relaxed somehow, or should it be just documented that
> enclave VMAs do not get merged?
The special check feels a bit odd for me, given that
1. It's hard to imagine anything that would not be "special", and
still would implement vma_close(). I presume that something
like this exists. Just cannot make up anything.
2. On the other hand, is_mergeable_vma() pretty much sets the
constraints to merge to VMA's into one. Most importantly
it checks that vm_close() is not implemented and VMA's
map the same file.
BR, Jarkko
prev parent reply other threads:[~2022-06-06 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 1:20 VMA's not getting merged Jarkko Sakkinen
2022-05-16 14:13 ` Dave Hansen
2022-05-16 18:45 ` Jarkko Sakkinen
2022-05-18 0:47 ` Jarkko Sakkinen
2022-06-06 7:21 ` Jarkko Sakkinen
2022-06-06 11:40 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp3npNLu6Blaphxk@iki.fi \
--to=jarkko@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=nathaniel@profian.com \
--cc=reinette.chatre@intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).