From: Jarkko Sakkinen <jarkko@kernel.org>
To: Zhiquan Li <zhiquan1.li@intel.com>
Cc: linux-sgx@vger.kernel.org, tony.luck@intel.com,
dave.hansen@linux.intel.com, seanjc@google.com,
kai.huang@intel.com, fan.du@intel.com
Subject: Re: [PATCH v2 1/4] x86/sgx: Move struct sgx_vepc definition to sgx.h
Date: Fri, 20 May 2022 00:30:10 +0300 [thread overview]
Message-ID: <Yoa24o8df+371sQ0@iki.fi> (raw)
In-Reply-To: <20220519031117.245698-1-zhiquan1.li@intel.com>
On Thu, May 19, 2022 at 11:11:17AM +0800, Zhiquan Li wrote:
> Move struct sgx_vepc definition to sgx.h so that it can be used outside
> of virt.c.
>
> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>
> ---
> Changes since V1:
> - Add documentation suggested by Jarkko.
> ---
> arch/x86/kernel/cpu/sgx/sgx.h | 13 +++++++++++++
> arch/x86/kernel/cpu/sgx/virt.c | 5 -----
> 2 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/sgx/sgx.h b/arch/x86/kernel/cpu/sgx/sgx.h
> index 0f17def9fe6f..ad3b455ed0da 100644
> --- a/arch/x86/kernel/cpu/sgx/sgx.h
> +++ b/arch/x86/kernel/cpu/sgx/sgx.h
> @@ -101,4 +101,17 @@ static inline int __init sgx_vepc_init(void)
>
> void sgx_update_lepubkeyhash(u64 *lepubkeyhash);
>
> +/**
> + * struct sgx_vepc - SGX virtual EPC structure
> + * @page_array: the xarray of virtual EPC pages allocated to guest
> + * @lock: the mutex lock to protect a virtual EPC instance
> + *
> + * When hypervisor opens /dev/sgx_vepc a virtual EPC instance. The
> + * virtual EPC pages allocated to guest will be added to its page_array.
I would just write "page array".
> + */
> +struct sgx_vepc {
> + struct xarray page_array;
> + struct mutex lock;
> +};
> +
> #endif /* _X86_SGX_H */
> diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
> index 6a77a14eee38..c9c8638b5dc4 100644
> --- a/arch/x86/kernel/cpu/sgx/virt.c
> +++ b/arch/x86/kernel/cpu/sgx/virt.c
> @@ -18,11 +18,6 @@
> #include "encls.h"
> #include "sgx.h"
>
> -struct sgx_vepc {
> - struct xarray page_array;
> - struct mutex lock;
> -};
> -
> /*
> * Temporary SECS pages that cannot be EREMOVE'd due to having child in other
> * virtual EPC instances, and the lock to protect it.
> --
> 2.25.1
>
BR, Jarkko
prev parent reply other threads:[~2022-05-19 21:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 3:11 [PATCH v2 1/4] x86/sgx: Move struct sgx_vepc definition to sgx.h Zhiquan Li
2022-05-19 21:30 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yoa24o8df+371sQ0@iki.fi \
--to=jarkko@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tony.luck@intel.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).