From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: cgel.zte@gmail.com, dave.hansen@linux.intel.com,
tglx@linutronix.de, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] x86/sgx: simplify the return expression of sgx_drv_init()
Date: Sat, 7 May 2022 01:30:48 +0300 [thread overview]
Message-ID: <YnWhmNMHG4yE5qhX@kernel.org> (raw)
In-Reply-To: <a29146f2-271b-8471-f846-15f0f50e614d@intel.com>
On Thu, May 05, 2022 at 10:31:41AM -0700, Dave Hansen wrote:
> On 5/4/22 19:16, cgel.zte@gmail.com wrote:
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> >
> > Simplify the return expression.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
>
> Folks, I'd really encourage you to spend your time elsewhere. These
> "cleanup" or "simplify" patches as a whole have high rates of bugs. I
> don't trust them. Plus, they don't really make the code easier to
> understand.
I agree. I get this kind of clean up in the context of doing something
to the functionality (in the same path) but it does not live by its own.
Plus, these type of patches add to the effort backporting fixes.
BR, Jarkko
prev parent reply other threads:[~2022-05-06 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 2:16 [PATCH] x86/sgx: simplify the return expression of sgx_drv_init() cgel.zte
2022-05-05 17:31 ` Dave Hansen
2022-05-06 22:30 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnWhmNMHG4yE5qhX@kernel.org \
--to=jarkko@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).