From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Dave Hansen" <dave.hansen@intel.com>, <linux-sgx@vger.kernel.org>
Cc: <stable@vger.kernel.org>, "kernel test robot" <lkp@intel.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Jethro Beekman" <jethro@fortanix.com>,
"Serge Ayoun" <serge.ayoun@intel.com>,
"Sean Christopherson" <seanjc@google.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/sgx: Describe the parameters of sgx_calc_section_metric()
Date: Sun, 27 Aug 2023 21:38:15 +0300 [thread overview]
Message-ID: <CV3JNOUEC8MH.3SE01XJKM6F43@suppilovahvero> (raw)
In-Reply-To: <ba319881-b4e9-7129-123f-1884bfeb50ec@intel.com>
On Fri Aug 25, 2023 at 6:18 PM EEST, Dave Hansen wrote:
> On 8/22/23 03:28, Jarkko Sakkinen wrote:
> > Cc: stable@vger.kernel.org # v5.11+
> > Fixes: e7e0545299d8 ("x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308221542.11UpkVfp-lkp@intel.com/
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> -ENOCHANGELOG
ack
> > /**
> > + * sgx_calc_section_metric() - Calculate an EPC section metric
> > + * @low: low 32-bit word from CPUID:0x12:{2, ...}
> > + * @high: high 32-bit word from CPUID:0x12:{2, ...}
> > + *
> > * A section metric is concatenated in a way that @low bits 12-31 define the
> > * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
> > * metric.
>
> Shouldn't we just do:
>
> - /**
> + /*
>
> ? This doesn't need kerneldoc comments.
Yeah, I added it because of parameter descriptions, which I think are
still useful.
If checkpatch does not complain, I can change the comment type.
BR, Jarkko
prev parent reply other threads:[~2023-08-27 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 10:28 [PATCH] x86/sgx: Describe the parameters of sgx_calc_section_metric() Jarkko Sakkinen
2023-08-25 15:18 ` Dave Hansen
2023-08-27 18:38 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CV3JNOUEC8MH.3SE01XJKM6F43@suppilovahvero \
--to=jarkko@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jethro@fortanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=serge.ayoun@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).