From: Jarkko Sakkinen <jarkko@kernel.org>
To: Zhao Mengmeng <zhaomzhao@126.com>,
dave.hansen@linux.intel.com, shuah@kernel.org,
jethro@fortanix.com, bp@suse.de
Cc: linux-sgx@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhao Mengmeng <zhaomengmeng@kylinos.cn>
Subject: Re: [PATCH v1] selftests/sgx: Skip non X86_64 platform
Date: Thu, 07 Dec 2023 06:31:21 +0200 [thread overview]
Message-ID: <68e7665a3962c05654bff4e8627f32bed81dc4f3.camel@kernel.org> (raw)
In-Reply-To: <20231206025605.3965302-1-zhaomzhao@126.com>
On Tue, 2023-12-05 at 21:56 -0500, Zhao Mengmeng wrote:
> From: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
>
> When building whole selftests on arm64, rsync gives an erorr about
> sgx:
>
> rsync: [sender] link_stat "/root/linux-
> next/tools/testing/selftests/sgx/test_encl.elf" failed: No such file
> or directory (2)
> rsync error: some files/attrs were not transferred (see previous
> errors) (code 23) at main.c(1327) [sender=3.2.5]
>
> The root casue is sgx only used on X86_64, and shall be skipped on
> other
> platforms.
>
> Fix this by moving TEST_CUSTOM_PROGS and TEST_FILES inside the if
> check,
> then the build result will be "Skipping non-existent dir: sgx".
>
> Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
> Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
> ---
> tools/testing/selftests/sgx/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/sgx/Makefile
> b/tools/testing/selftests/sgx/Makefile
> index 50aab6b57da3..01abe4969b0f 100644
> --- a/tools/testing/selftests/sgx/Makefile
> +++ b/tools/testing/selftests/sgx/Makefile
> @@ -16,10 +16,10 @@ HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
> -z noexecstack
> ENCL_CFLAGS := -Wall -Werror -static -nostdlib -nostartfiles -fPIC \
> -fno-stack-protector -mrdrnd $(INCLUDES)
>
> +ifeq ($(CAN_BUILD_X86_64), 1)
> TEST_CUSTOM_PROGS := $(OUTPUT)/test_sgx
> TEST_FILES := $(OUTPUT)/test_encl.elf
>
> -ifeq ($(CAN_BUILD_X86_64), 1)
> all: $(TEST_CUSTOM_PROGS) $(OUTPUT)/test_encl.elf
> endif
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2023-12-07 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 2:56 [PATCH v1] selftests/sgx: Skip non X86_64 platform Zhao Mengmeng
2023-12-07 4:31 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68e7665a3962c05654bff4e8627f32bed81dc4f3.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=jethro@fortanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zhaomengmeng@kylinos.cn \
--cc=zhaomzhao@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).