From: Zhiquan Li <zhiquan1.li@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: <linux-sgx@vger.kernel.org>, <tony.luck@intel.com>,
<dave.hansen@linux.intel.com>, <seanjc@google.com>,
<fan.du@intel.com>, <zhiquan1.li@intel.com>
Subject: Re: [PATCH 1/4] x86/sgx: Move struct sgx_vepc definition to sgx.h
Date: Thu, 12 May 2022 20:10:19 +0800 [thread overview]
Message-ID: <39a50db6-39f6-28b5-9655-8e92f4810b33@intel.com> (raw)
In-Reply-To: <YnuQlEAG6kEAbLY2@kernel.org>
On 2022/5/11 18:31, Jarkko Sakkinen wrote:
> On Tue, May 10, 2022 at 11:17:25AM +0800, Zhiquan Li wrote:
>> Move struct sgx_vepc definition to sgx.h so that it can be used outside
>> of virt.c.
>>
>> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>
>> ---
>> arch/x86/kernel/cpu/sgx/sgx.h | 5 +++++
>> arch/x86/kernel/cpu/sgx/virt.c | 5 -----
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/sgx/sgx.h b/arch/x86/kernel/cpu/sgx/sgx.h
>> index 0f17def9fe6f..83ff8c3e81cf 100644
>> --- a/arch/x86/kernel/cpu/sgx/sgx.h
>> +++ b/arch/x86/kernel/cpu/sgx/sgx.h
>> @@ -101,4 +101,9 @@ static inline int __init sgx_vepc_init(void)
>>
>> void sgx_update_lepubkeyhash(u64 *lepubkeyhash);
>>
>> +struct sgx_vepc {
>> + struct xarray page_array;
>> + struct mutex lock;
>> +};
>
> Would not BTW hurt to add some documentation for this struct, while at it.
> Nothing wrong with the code change itself but what about adding a brief
> explanation what it is?
No problem, I will add some documentation in v2 patch.
Best Regards,
Zhiquan
>
>> +
>> #endif /* _X86_SGX_H */
>> diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
>> index 6a77a14eee38..c9c8638b5dc4 100644
>> --- a/arch/x86/kernel/cpu/sgx/virt.c
>> +++ b/arch/x86/kernel/cpu/sgx/virt.c
>> @@ -18,11 +18,6 @@
>> #include "encls.h"
>> #include "sgx.h"
>>
>> -struct sgx_vepc {
>> - struct xarray page_array;
>> - struct mutex lock;
>> -};
>> -
>> /*
>> * Temporary SECS pages that cannot be EREMOVE'd due to having child in other
>> * virtual EPC instances, and the lock to protect it.
>> --
>> 2.25.1
>>
prev parent reply other threads:[~2022-05-12 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:17 [PATCH 1/4] x86/sgx: Move struct sgx_vepc definition to sgx.h Zhiquan Li
2022-05-11 10:31 ` Jarkko Sakkinen
2022-05-12 12:10 ` Zhiquan Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a50db6-39f6-28b5-9655-8e92f4810b33@intel.com \
--to=zhiquan1.li@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=jarkko@kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).