From: "Huang, Kai" <kai.huang@intel.com>
To: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"jinpu.wang@ionos.com" <jinpu.wang@ionos.com>
Cc: "yu.zhang@ionos.com" <yu.zhang@ionos.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"haitao.huang@linux.intel.com" <haitao.huang@linux.intel.com>
Subject: Re: [PATCHv3] x86/sgx: Avoid softlockup from sgx_vepc_release
Date: Fri, 18 Aug 2023 21:33:51 +0000 [thread overview]
Message-ID: <2999685f286789d43e3b1f13c4cb65efd008d820.camel@intel.com> (raw)
In-Reply-To: <20230818180702.4621-1-jinpu.wang@ionos.com>
On Fri, 2023-08-18 at 20:07 +0200, Jack Wang wrote:
> We hit softlocup with following call trace:
>
> ? asm_sysvec_apic_timer_interrupt+0x16/0x20
> xa_erase+0x21/0xb0
> ? sgx_free_epc_page+0x20/0x50
> sgx_vepc_release+0x75/0x220
> __fput+0x89/0x250
> task_work_run+0x59/0x90
> do_exit+0x337/0x9a0
>
> Similar like commit 8795359e35bc ("x86/sgx: Silence softlockup detection
> when releasing large enclaves"). The test system has 64GB of enclave memory,
> and all assigned to a single VM. Release vepc take longer time and triggers
> the softlockup warning.
>
> Add cond_resched() to give other tasks a chance to run and placate
> the softlockup detector.
>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Haitao Huang <haitao.huang@linux.intel.com>
> Cc: stable@vger.kernel.org
> Fixes: 540745ddbc70 ("x86/sgx: Introduce virtual EPC for use by KVM guests")
> Reported-by: Yu Zhang <yu.zhang@ionos.com>
> Tested-by: Yu Zhang <yu.zhang@ionos.com>
> Acked-by: Haitao Huang <haitao.huang@linux.intel.com>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
prev parent reply other threads:[~2023-08-18 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 18:07 [PATCHv3] x86/sgx: Avoid softlockup from sgx_vepc_release Jack Wang
2023-08-18 18:08 ` Jarkko Sakkinen
2023-08-18 21:33 ` Huang, Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2999685f286789d43e3b1f13c4cb65efd008d820.camel@intel.com \
--to=kai.huang@intel.com \
--cc=haitao.huang@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jinpu.wang@ionos.com \
--cc=linux-sgx@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yu.zhang@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).