From: Zhiquan Li <zhiquan1.li@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: <dave.hansen@linux.intel.com>, <linux-sgx@vger.kernel.org>,
<tony.luck@intel.com>, <tglx@linutronix.de>, <bp@alien8.de>,
<seanjc@google.com>, <kai.huang@intel.com>, <fan.du@intel.com>,
<cathy.zhang@intel.com>
Subject: Re: [PATCH RESEND v6 1/3] x86/sgx: Rename the owner field of struct sgx_epc_page as encl_owner
Date: Tue, 30 Aug 2022 10:24:31 +0800 [thread overview]
Message-ID: <20a17b1d-eba3-8502-d6cd-038d5d44687e@intel.com> (raw)
In-Reply-To: <YwytkoKoK2TmXPva@kernel.org>
On 2022/8/29 20:14, Jarkko Sakkinen wrote:
> On Mon, Aug 29, 2022 at 09:23:48AM +0800, Zhiquan Li wrote:
>>
>> On 2022/8/28 11:27, Jarkko Sakkinen wrote:
>>> On Sat, Aug 27, 2022 at 12:05:01AM +0800, Zhiquan Li wrote:
>>>> In order to describe the purpose of 'owner' field more exactly,
>>>> rename the 'owner' field of struct sgx_epc_page as 'encl_owner',
>>>> and update all of references.
>>>>
>>>> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>
>>> Is this rename really worth of doing? I'd only consider
>>> such if there was two 'owner' fields but since there is
>>> no name collision, why bother?
>>>
>>> Thoughts? Please correct me if I've forgot something
>>> essential previously discussed.
>>>
>>> BR, Jarkko
>>>
>>>
>>
>> Hello Jarkko,
>>
>> The field name and union comes from Dave's suggestion:
>>
>> https://lore.kernel.org/linux-sgx/Yrf27fugD7lkyaek@kernel.org/T/#m2ff4778948cdc9ee65f09672f1d02f8dc467247b
>>
>> - If the rename make the thing complicated we can consider drop this patch, it might introduce potential conflict with the SGX patches under reviewing.
>> - If you think the union introduced by patch 02 is also unnecessary, then we need to discuss it with Dave.
>>
>> Best Regards,
>> Zhiquan
>
> "In order to avoid unnecessary casting" might then be a better
> way to start the sentence.
>
> BR, Jarkko
No problem, I'll revise the commit message and send V7 soon.
Thanks for your review.
Best Regards,
Zhiquan
next prev parent reply other threads:[~2022-08-30 2:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 16:05 [PATCH RESEND v6 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-08-26 16:05 ` [PATCH RESEND v6 1/3] x86/sgx: Rename the owner field of struct sgx_epc_page as encl_owner Zhiquan Li
2022-08-28 3:27 ` Jarkko Sakkinen
2022-08-29 1:23 ` Zhiquan Li
2022-08-29 12:14 ` Jarkko Sakkinen
2022-08-30 2:24 ` Zhiquan Li [this message]
2022-08-26 16:05 ` [PATCH RESEND v6 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case Zhiquan Li
2022-08-27 21:47 ` Jarkko Sakkinen
2022-08-29 1:27 ` Zhiquan Li
2022-08-29 12:29 ` Jarkko Sakkinen
2022-08-26 16:05 ` [PATCH RESEND v6 3/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a17b1d-eba3-8502-d6cd-038d5d44687e@intel.com \
--to=zhiquan1.li@intel.com \
--cc=bp@alien8.de \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).