From: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
To: jarkko@kernel.org, kai.huang@intel.com,
linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dave.hansen@linux.intel.com, Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
Subject: [PATCH v3 0/9] selftests/sgx: Fix compilation errors
Date: Sat, 19 Aug 2023 11:43:23 +0200 [thread overview]
Message-ID: <20230819094332.8535-1-jo.vanbulck@cs.kuleuven.be> (raw)
Hi,
This is the third iteration of a patch series to ensure that all SGX selftests
succeed when compiling with optimizations (as tested with -O{0,1,2,3,s} for
both gcc 11.3.0 and clang 14.0.0). The aim of the patches is to avoid reliance
on undefined, compiler-specific behavior that can make the test results
fragile.
If useful, I can also include an elementary wrapper shell script to compile and
run the tests for different compilers (gcc/clang) and optimization levels.
Reference output below:
.. Testing gcc -O0 [OK]
.. Testing gcc -O1 [OK]
.. Testing gcc -O2 [OK]
.. Testing gcc -O3 [OK]
.. Testing gcc -Os [OK]
.. Testing gcc -Ofast [OK]
.. Testing gcc -Og [OK]
.. Testing clang -O0 [OK]
.. Testing clang -O1 [OK]
.. Testing clang -O2 [OK]
.. Testing clang -O3 [OK]
.. Testing clang -Os [OK]
.. Testing clang -Ofast [OK]
.. Testing clang -Og [OK]
Changelog
---------
v3
- Refactor encl_op_array declaration and indexing (Jarkko)
- Annotate encl_buffer with "used" attribute (Kai)
- Split encl_buffer size and placement commits (Kai)
v2
- Add additional check for NULL pointer (Kai)
- Refine to produce proper static-pie executable
- Fix linker script assertions
- Specify memory clobber for inline asm instead of volatile (Kai)
- Clarify why encl_buffer non-static (Jarkko, Kai)
- Clarify -ffreestanding (Jarkko)
Best,
Jo
Jo Van Bulck (9):
selftests/sgx: Fix uninitialized pointer dereference in error path
selftests/sgx: Produce static-pie executable for test enclave
selftests/sgx: Handle relocations in test enclave
selftests/sgx: Fix linker script asserts
selftests/sgx: Include memory clobber for inline asm in test enclave
selftests/sgx: Ensure test enclave buffer is entirely preserved
selftests/sgx: Ensure expected location of test enclave buffer
selftests/sgx: Separate linker options
selftests/sgx: Specify freestanding environment for enclave
compilation
tools/testing/selftests/sgx/Makefile | 14 ++--
tools/testing/selftests/sgx/defines.h | 2 +
tools/testing/selftests/sgx/sigstruct.c | 5 +-
tools/testing/selftests/sgx/test_encl.c | 66 ++++++++++++-------
tools/testing/selftests/sgx/test_encl.lds | 10 +--
.../selftests/sgx/test_encl_bootstrap.S | 12 ++--
6 files changed, 68 insertions(+), 41 deletions(-)
--
2.25.1
next reply other threads:[~2023-08-19 10:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 9:43 Jo Van Bulck [this message]
2023-08-19 9:43 ` [PATCH v3 1/9] selftests/sgx: Fix uninitialized pointer dereference in error path Jo Van Bulck
2023-08-19 9:43 ` [PATCH v3 2/9] selftests/sgx: Produce static-pie executable for test enclave Jo Van Bulck
2023-08-22 0:26 ` Huang, Kai
2023-08-23 13:19 ` Jo Van Bulck
2023-08-19 9:43 ` [PATCH v3 3/9] selftests/sgx: Handle relocations in " Jo Van Bulck
2023-08-22 1:11 ` Huang, Kai
2023-08-25 13:27 ` Jo Van Bulck
2023-08-22 10:08 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 4/9] selftests/sgx: Fix linker script asserts Jo Van Bulck
2023-08-22 10:09 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 5/9] selftests/sgx: Include memory clobber for inline asm in test enclave Jo Van Bulck
2023-08-22 10:10 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 6/9] selftests/sgx: Ensure test enclave buffer is entirely preserved Jo Van Bulck
2023-08-21 11:10 ` Huang, Kai
2023-08-22 10:10 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 7/9] selftests/sgx: Ensure expected location of test enclave buffer Jo Van Bulck
2023-08-21 11:10 ` Huang, Kai
2023-08-22 10:11 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 8/9] selftests/sgx: Separate linker options Jo Van Bulck
2023-08-22 10:11 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 9/9] selftests/sgx: Specify freestanding environment for enclave compilation Jo Van Bulck
2023-08-22 10:14 ` Jarkko Sakkinen
2023-08-23 12:57 ` Jo Van Bulck
2023-08-23 17:31 ` Jarkko Sakkinen
2023-08-22 10:31 ` [PATCH v3 0/9] selftests/sgx: Fix compilation errors Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230819094332.8535-1-jo.vanbulck@cs.kuleuven.be \
--to=jo.vanbulck@cs.kuleuven.be \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).