From: Jack Wang <jinpu.wang@ionos.com>
To: jarkko@kernel.org
Cc: linux-sgx@vger.kernel.org,
Haitao Huang <haitao.huang@linux.intel.com>,
Yu Zhang <yu.zhang@ionos.com>
Subject: [PATCH] x86/sgx: Avoid softlockup from sgx_vepc_release
Date: Mon, 14 Aug 2023 06:37:14 +0200 [thread overview]
Message-ID: <20230814043714.107971-1-jinpu.wang@ionos.com> (raw)
We hit softlocup with following call trace:
kernel: [ 2041.288210] Call Trace:
kernel: [ 2041.288213] <IRQ>
kernel: [ 2041.288216] ? watchdog_timer_fn+0x1b4/0x210
kernel: [ 2041.288222] ? lockup_detector_update_enable+0x50/0x50
kernel: [ 2041.288225] ? __hrtimer_run_queues+0x127/0x280
kernel: [ 2041.288230] ? hrtimer_interrupt+0xfc/0x210
kernel: [ 2041.288233] ? __sysvec_apic_timer_interrupt+0x59/0xd0
kernel: [ 2041.288237] ? sysvec_apic_timer_interrupt+0x6d/0x90
kernel: [ 2041.288242] </IRQ>
kernel: [ 2041.288242] <TASK>
kernel: [ 2041.288244] ? asm_sysvec_apic_timer_interrupt+0x16/0x20
kernel: [ 2041.288250] xa_erase+0x21/0xb0
kernel: [ 2041.288256] ? sgx_free_epc_page+0x20/0x50
kernel: [ 2041.288260] sgx_vepc_release+0x75/0x220
kernel: [ 2041.288263] __fput+0x89/0x250
kernel: [ 2041.288269] task_work_run+0x59/0x90
kernel: [ 2041.288275] do_exit+0x337/0x9a0
Similar like 8795359e35bc ("x86/sgx: Silence softlockup detection when releasing large enclaves")
The test system has 64GB of enclave memory, and all assigned to a single
VM. Release vepc take longer time and triggers the softlockup warning.
Add a cond_resched() to give other tasks a chance to run and placate
the softlockup detector.
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Haitao Huang <haitao.huang@linux.intel.com>
Reported-by: Yu Zhang <yu.zhang@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
arch/x86/kernel/cpu/sgx/virt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/kernel/cpu/sgx/virt.c b/arch/x86/kernel/cpu/sgx/virt.c
index c3e37eaec8ec..01d2795792cc 100644
--- a/arch/x86/kernel/cpu/sgx/virt.c
+++ b/arch/x86/kernel/cpu/sgx/virt.c
@@ -204,6 +204,7 @@ static int sgx_vepc_release(struct inode *inode, struct file *file)
continue;
xa_erase(&vepc->page_array, index);
+ cond_resched();
}
/*
@@ -222,6 +223,7 @@ static int sgx_vepc_release(struct inode *inode, struct file *file)
list_add_tail(&epc_page->list, &secs_pages);
xa_erase(&vepc->page_array, index);
+ cond_resched();
}
/*
--
2.34.1
next reply other threads:[~2023-08-14 4:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 4:37 Jack Wang [this message]
2023-08-14 17:35 ` [PATCH] x86/sgx: Avoid softlockup from sgx_vepc_release Jarkko Sakkinen
2023-08-14 23:58 ` Huang, Kai
2023-08-16 20:34 ` Jarkko Sakkinen
2023-08-17 7:39 ` Jinpu Wang
2023-08-17 7:38 ` Jinpu Wang
2023-08-17 10:00 ` Huang, Kai
2023-08-17 16:01 ` Jarkko Sakkinen
2023-08-18 8:12 ` Jinpu Wang
2023-08-15 13:57 ` Haitao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814043714.107971-1-jinpu.wang@ionos.com \
--to=jinpu.wang@ionos.com \
--cc=haitao.huang@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=yu.zhang@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).