From: "Huang, Kai" <kai.huang@intel.com>
To: "jarkko@kernel.org" <jarkko@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 3/3] x86/sgx: Add xa_store_range() return value check in sgx_setup_epc_section()
Date: Tue, 1 Nov 2022 02:41:39 +0000 [thread overview]
Message-ID: <0b22047833ec63106b7b2c97ca0dcda0bd16470b.camel@intel.com> (raw)
In-Reply-To: <57b607fa66a84996174fd16be415ec65dbffe8d4.camel@intel.com>
On Tue, 2022-10-04 at 22:42 +0000, Huang, Kai wrote:
> On Wed, 2022-10-05 at 01:21 +0300, Jarkko Sakkinen wrote:
> > On Tue, Oct 04, 2022 at 11:04:29AM +1300, Kai Huang wrote:
> > > In sgx_setup_epc_section(), xa_store_range() is called to store EPC
> > > pages' owner section to an Xarray using physical addresses of those EPC
> > > pages as index. Currently, the return value of xa_store_range() is not
> > > checked, but actually it can fail (i.e. due to -ENOMEM).
> > >
> > > Not checking the return value of xa_store_range() would result in the
> > > EPC section being used by SGX driver (and KVM SGX guests), but part or
> > > all of its EPC pages not being handled by the memory failure handling of
> > > EPC page. Such inconsistency should be avoided, even at the cost that
> > > this section won't be used by the kernel.
> > >
> > > Add the missing check of the return value of xa_store_range(), and when
> > > it fails, clean up and fail to initialize the EPC section.
> > >
> > > Fixes: 40e0e7843e23 ("x86/sgx: Add infrastructure to identify SGX EPC pages")
> > > Signed-off-by: Kai Huang <kai.huang@intel.com>
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > This needs:
> >
> > Cc: stable@vger.kernel.org # v5.17+
> >
> > Dave, can you pick this independently of rest of the patch set
> > (unless ofc you have change suggestions)?
> >
> > BR, Jarkko
>
> Thanks Jarkko. I will add the "Cc stable" part if I need to send out a new
> version.
>
> --
> Thanks,
> -Kai
>
Hi Dave,
Is this patch worth to do? For now this should be more like a theoretical issue
that I just saw when scanning the code. If it is worth to do I'll send out a
new one with Jarkko's reviewed-by and CC stable tag.
--
Thanks,
-Kai
prev parent reply other threads:[~2022-11-01 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 22:04 [PATCH 0/3] Minor improvements to sgx_init() Kai Huang
2022-10-03 22:04 ` [PATCH 1/3] x86/sgx: Start the ksgxd() at the end of sgx_init() Kai Huang
2022-10-03 22:04 ` [PATCH 2/3] x86/sgx: Only run the reclaimer when the native SGX driver is enabled Kai Huang
2022-10-03 22:04 ` [RESEND PATCH 3/3] x86/sgx: Add xa_store_range() return value check in sgx_setup_epc_section() Kai Huang
2022-10-04 22:21 ` Jarkko Sakkinen
2022-10-04 22:42 ` Huang, Kai
2022-11-01 2:41 ` Huang, Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b22047833ec63106b7b2c97ca0dcda0bd16470b.camel@intel.com \
--to=kai.huang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).