From: Serge Semin <fancer.lancer@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Viresh Kumar" <vireshk@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
dmaengine@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dmaengine: dw: Simplify prepare CTL_LO methods
Date: Fri, 19 Apr 2024 12:19:48 +0300 [thread overview]
Message-ID: <oqyz6fpdxzk5x4xr5rlqwnj3frakjnz24e6bx7mxngh5gm5jom@wsm7qvubqwn3> (raw)
In-Reply-To: <ZiGJ-DspJq5R6Dym@smile.fi.intel.com>
On Fri, Apr 19, 2024 at 12:00:40AM +0300, Andy Shevchenko wrote:
> On Thu, Apr 18, 2024 at 10:00:02PM +0300, Serge Semin wrote:
> > On Thu, Apr 18, 2024 at 02:47:18PM +0300, Andy Shevchenko wrote:
> > > On Wed, Apr 17, 2024 at 11:11:46PM +0300, Serge Semin wrote:
> > > > On Tue, Apr 16, 2024 at 10:04:42PM +0300, Andy Shevchenko wrote:
> > > > > On Tue, Apr 16, 2024 at 07:28:57PM +0300, Serge Semin wrote:
>
> ...
>
> > > > > > + if (dwc->direction == DMA_MEM_TO_DEV) {
> > > > > > + sms = dwc->dws.m_master;
> > > > > > + smsize = 0;
> > > > > > + dms = dwc->dws.p_master;
> > > > > > + dmsize = sconfig->dst_maxburst;
> > > >
> > > > > I would group it differently, i.e.
> > > > >
> > > > > sms = dwc->dws.m_master;
> > > > > dms = dwc->dws.p_master;
> > > > > smsize = 0;
> > > > > dmsize = sconfig->dst_maxburst;
> > > >
> > > > Could you please clarify, why? From my point of view it was better to
> > > > group the source master ID and the source master burst size inits
> > > > together.
> >
> > > Sure. The point here is that when you look at the DMA channel configuration
> > > usually you operate with the semantically tied fields for source and
> > > destination. At least this is my experience, I always check both sides
> > > of the transfer for the same field, e.g., master setting, hence I want to
> > > have them coupled.
> >
> > Ok. I see. Thanks for clarification. I normally do that in another
> > order: group the functionally related fields together - all
> > source-related configs first, then all destination-related configs.
> > Honestly I don't have strong opinion about this part, it's just my
> > personal preference. Am I right to think that from your experience in
> > kernel it's normally done in the order you described?
>
> In this driver I believe I have followed that one, yes.
Agreed then. I'll change the order to the way you ask.
-Serge(y)
>
> > > > > > + } else if (dwc->direction == DMA_DEV_TO_MEM) {
> > > > > > + sms = dwc->dws.p_master;
> > > > > > + smsize = sconfig->src_maxburst;
> > > > > > + dms = dwc->dws.m_master;
> > > > > > + dmsize = 0;
> > > > > > + } else /* DMA_MEM_TO_MEM */ {
> > > > > > + sms = dwc->dws.m_master;
> > > > > > + smsize = 0;
> > > > > > + dms = dwc->dws.m_master;
> > > > > > + dmsize = 0;
> > > > > > + }
> > > > >
> > > > > Ditto for two above cases.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2024-04-19 9:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 16:28 [PATCH 0/4] dmaengine: dw: Fix src/dst addr width misconfig Serge Semin
2024-04-16 16:28 ` [PATCH 1/4] dmaengine: dw: Add peripheral bus width verification Serge Semin
2024-04-16 18:00 ` Andy Shevchenko
2024-04-17 19:54 ` Serge Semin
2024-04-18 9:43 ` Andy Shevchenko
2024-04-18 15:47 ` Serge Semin
2024-04-16 16:28 ` [PATCH 2/4] dmaengine: dw: Add memory " Serge Semin
2024-04-16 18:47 ` Andy Shevchenko
2024-04-17 17:13 ` Serge Semin
2024-04-17 17:28 ` Andy Shevchenko
2024-04-17 18:52 ` Serge Semin
2024-04-18 9:37 ` Andy Shevchenko
2024-04-18 15:52 ` Serge Semin
2024-04-16 16:28 ` [PATCH 3/4] dmaengine: dw: Simplify prepare CTL_LO methods Serge Semin
2024-04-16 19:04 ` Andy Shevchenko
2024-04-17 20:11 ` Serge Semin
2024-04-18 11:47 ` Andy Shevchenko
2024-04-18 19:00 ` Serge Semin
2024-04-18 21:00 ` Andy Shevchenko
2024-04-19 9:19 ` Serge Semin [this message]
2024-04-16 16:28 ` [PATCH 4/4] dmaengine: dw: Simplify max-burst calculation procedure Serge Semin
2024-04-16 19:11 ` Andy Shevchenko
2024-04-17 20:35 ` Serge Semin
2024-04-18 11:49 ` Andy Shevchenko
2024-04-18 19:10 ` Serge Semin
2024-04-16 19:13 ` [PATCH 0/4] dmaengine: dw: Fix src/dst addr width misconfig Andy Shevchenko
2024-04-17 17:34 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oqyz6fpdxzk5x4xr5rlqwnj3frakjnz24e6bx7mxngh5gm5jom@wsm7qvubqwn3 \
--to=fancer.lancer@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).