From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Wadim Mueller <wafgo01@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Chester Lin" <chester62515@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Matthias Brugger" <mbrugger@suse.com>,
"NXP S32 Linux Team" <s32@nxp.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Gregor Herburger" <gregor.herburger@ew.tq-group.com>,
"Marek Vasut" <marex@denx.de>,
"Joao Paulo Goncalves" <joao.goncalves@toradex.com>,
"Markus Niebel" <Markus.Niebel@ew.tq-group.com>,
"Matthias Schiffer" <matthias.schiffer@tq-group.com>,
"Stefan Wahren" <stefan.wahren@chargebyte.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Yannic Moog" <y.moog@phytec.de>, "Li Yang" <leoyang.li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 3/4] dt-bindings: mmc: fsl-imx-esdhc: add NXP S32G3 support
Date: Fri, 22 Mar 2024 16:02:23 +0100 [thread overview]
Message-ID: <f360ab66-1ee5-485a-84a9-f431b0c248a3@linaro.org> (raw)
In-Reply-To: <20240322094526.GA7097@bhlegrsu.conti.de>
On 22/03/2024 10:45, Wadim Mueller wrote:
> On Thu, Mar 21, 2024 at 06:53:34PM +0100, Krzysztof Kozlowski wrote:
>> On 21/03/2024 16:41, Wadim Mueller wrote:
>>> Add a compatible string for the SDHC binding of NXP S32G3 platforms. Here
>>> we use "nxp,s32g2-usdhc" as fallback since the s32g2-usdhc
>>> driver works also on S32G3 platforms.
>>>
>>> Signed-off-by: Wadim Mueller <wafgo01@gmail.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> index 82eb7a24c857..b42b4368fa4e 100644
>>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
>>> @@ -35,6 +35,7 @@ properties:
>>> - fsl,imx8mm-usdhc
>>> - fsl,imxrt1050-usdhc
>>> - nxp,s32g2-usdhc
>>> + - nxp,s32g3-usdhc
>>> - items:
>>> - const: fsl,imx50-esdhc
>>> - const: fsl,imx53-esdhc
>>> @@ -90,6 +91,9 @@ properties:
>>> - enum:
>>> - fsl,imxrt1170-usdhc
>>> - const: fsl,imxrt1050-usdhc
>>> + - items:
>>> + - const: nxp,s32g3-usdhc
>>> + - const: nxp,s32g2-usdhc
>>
>> No, that's just wrong. G3 is not and is compatible with G2? There is no
>> dualism here. Either it is or it is not. Not both.
>>
>
> I am trying to understand your statement but I am not sure whether I get
> it right.
>
> Let me try to explain what I understand is wrong with this patch.
>
> Having nxp,s32g2-usdhc and nxp,s32g2-usdhc in one enum
>
>>> - nxp,s32g2-usdhc
>>> + - nxp,s32g3-usdhc
>
> would mean that those are
> __not__ compatible with each other, whereas the anouther item
>
>>> + - items:
>>> + - const: nxp,s32g3-usdhc
>>> + - const: nxp,s32g2-usdhc
>>
>
> where both const entries are side by side means that those are compatible. Which is
> paradox. Is this undersanding correct?
Yes, you placed the same compatible in two separate places. It has two
separate meanings.
>
> So if I want to have the follwing im my DTS for the mmc node
>
> usdhc0: mmc@402f0000 {
> compatible = "nxp,s32g3-usdhc",
> "nxp,s32g2-usdhc";
> ...
> }
>
> The schema update should contain just this part?
>
> i@@ -90,6 +90,9 @@ properties:
> - enum:
> - fsl,imxrt1170-usdhc
> - const: fsl,imxrt1050-usdhc
> + - items:
> + - const: nxp,s32g3-usdhc
> + - const: nxp,s32g2-usdhc
>
> reg:
> maxItems: 1
>
>
> Is this correct?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-22 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 15:41 [PATCH v3 0/4] NXP S32G3 SoC initial bring-up Wadim Mueller
2024-03-21 15:41 ` [PATCH v3 1/4] dt-bindings: arm: fsl: Document NXP S32G3 board Wadim Mueller
2024-03-21 17:52 ` Krzysztof Kozlowski
2024-03-21 15:41 ` [PATCH v3 2/4] dt-bindings: serial: fsl-linflexuart: add compatible for S32G3 Wadim Mueller
2024-03-21 17:52 ` Krzysztof Kozlowski
2024-03-21 15:41 ` [PATCH v3 3/4] dt-bindings: mmc: fsl-imx-esdhc: add NXP S32G3 support Wadim Mueller
2024-03-21 17:53 ` Krzysztof Kozlowski
2024-03-22 9:45 ` Wadim Mueller
2024-03-22 15:02 ` Krzysztof Kozlowski [this message]
2024-03-21 15:41 ` [PATCH v3 4/4] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3 Wadim Mueller
2024-03-21 17:54 ` Krzysztof Kozlowski
2024-03-22 14:52 ` Ghennadi Procopciuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f360ab66-1ee5-485a-84a9-f431b0c248a3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=afaerber@suse.de \
--cc=bhelgaas@google.com \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregor.herburger@ew.tq-group.com \
--cc=jirislaby@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=matthias.schiffer@tq-group.com \
--cc=mbrugger@suse.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@chargebyte.com \
--cc=tharvey@gateworks.com \
--cc=ulf.hansson@linaro.org \
--cc=wafgo01@gmail.com \
--cc=y.moog@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).