Linux-Serial Archive mirror
 help / color / mirror / Atom feed
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: add support for A5 based Amlogic AV400
Date: Wed, 20 Mar 2024 18:31:09 +0800	[thread overview]
Message-ID: <cc86991d-1c8c-4d49-bdf2-a8d451ddd039@amlogic.com> (raw)
In-Reply-To: <98b3fb64-2256-4280-bbfd-c944e5df829b@linaro.org>

Hi Krzysztof,
     Thanks for your reply.

On 2024/3/20 17:48, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 20/03/2024 10:44, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic A5 is an application processor designed for smart audio
>> and IoT applications.
>>
>> Add basic support for the A5 based Amlogic AV400 board, which describes
>> the following components: CPU, GIC, IRQ, Timer and UART.
>> These are capable of booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>>   .../boot/dts/amlogic/amlogic-a5-a113x2-av400.dts   | 42 ++++++++++++++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi        | 40 +++++++++++++++++++++
>>   3 files changed, 83 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 9a50ec11bb8d..154c9efb26e4 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,5 +1,6 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-a5-a113x2-av400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts b/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts
>> new file mode 100644
>> index 000000000000..2f5f5ea74bc9
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a5-a113x2-av400.dts
>> @@ -0,0 +1,42 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-a5.dtsi"
>> +
>> +/ {
>> +     model = "Amlogic A113X2 av400 Development Board";
>> +     compatible = "amlogic,av400","amlogic,a5";
> 
> Please fix missing space in all your patches.
> 
Will fix.
> 
> 
> Best regards,
> Krzysztof
> 

      reply	other threads:[~2024-03-20 10:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  9:44 [PATCH v2 0/5] Baisc devicetree support for Amlogic A4 and A5 Xianwei Zhao via B4 Relay
2024-03-20  9:44 ` [PATCH v2 1/5] dt-bindings: arm: amlogic: add A4 support Xianwei Zhao via B4 Relay
2024-03-20  9:44 ` [PATCH v2 2/5] dt-bindings: arm: amlogic: add A5 support Xianwei Zhao via B4 Relay
2024-03-20  9:44 ` [PATCH v2 3/5] dt-bindings: serial: amlogic,meson-uart: Add compatible string for A4 Xianwei Zhao via B4 Relay
2024-03-20  9:47   ` Krzysztof Kozlowski
2024-03-20  9:55     ` Xianwei Zhao
2024-03-20  9:44 ` [PATCH v2 4/5] arm64: dts: add support for A4 based Amlogic BA400 Xianwei Zhao via B4 Relay
2024-03-20  9:48   ` Krzysztof Kozlowski
2024-03-20 10:06     ` Xianwei Zhao
2024-03-20  9:44 ` [PATCH v2 5/5] arm64: dts: add support for A5 based Amlogic AV400 Xianwei Zhao via B4 Relay
2024-03-20  9:48   ` Krzysztof Kozlowski
2024-03-20 10:31     ` Xianwei Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc86991d-1c8c-4d49-bdf2-a8d451ddd039@amlogic.com \
    --to=xianwei.zhao@amlogic.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=jirislaby@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).