From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: lumingyindetect@126.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Date: Fri, 26 Apr 2024 18:37:54 +0300 [thread overview]
Message-ID: <ZivKUr0hyJOixLgL@smile.fi.intel.com> (raw)
In-Reply-To: <047e490b-0dbf-49b7-9506-996f0053e92d@moroto.mountain>
On Fri, Apr 26, 2024 at 06:32:33PM +0300, Dan Carpenter wrote:
> On Fri, Apr 26, 2024 at 05:45:49PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 26, 2024 at 04:53:18PM +0300, Dan Carpenter wrote:
> >
> > > > Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
> > >
> > > This is the wrong hash and the format is wrong. It should be:
> > >
> > > Fixes: 254cc7743e84 ("serial: 8250_lpss: Switch over to MSI interrupts")
> >
> > Since you are here, just pay attention that this does NOT fix anything
> > as it uses pcim_enable_device(). I hope smatch won't stumble over this
> > and produce false positives.
> >
>
> Ah... No, this isn't a Smatch warning. I think I tried to add it but
> was told it was wrong because I have this in my unpublished code. :P
>
> // Are these affected by pcim_enable_device()?
> // { "pci_alloc_irq_vectors", ALLOC, 0, "$", &int_one, &int_max },
> // { "pci_free_irq_vectors", RELEASE, 0, "$" },
>
> So when we're using pcim_enable_device(), calling pci_free_irq_vectors()
> is harmless but not necessary?
Yes, precisely.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-26 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 11:47 [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe() lumingyindetect
2024-04-26 12:28 ` Markus Elfring
2024-04-26 13:01 ` lumingyindetect
2024-04-26 13:51 ` Markus Elfring
2024-04-26 15:07 ` [PATCH] " Christian Heusel
2024-04-26 13:45 ` Ilpo Järvinen
2024-04-26 13:53 ` Dan Carpenter
2024-04-26 14:45 ` Andy Shevchenko
2024-04-26 15:32 ` Dan Carpenter
2024-04-26 15:37 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-26 13:39 lumingyindetect
2024-04-26 13:48 ` Ilpo Järvinen
2024-04-26 13:55 ` Greg KH
2024-04-26 14:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZivKUr0hyJOixLgL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=11570291+yin-luming@user.noreply.gitee.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lumingyindetect@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).