From: Sreenath Vijayan <sreenath.vijayan@sony.com>
To: pmladek@suse.com, john.ogness@linutronix.de, corbet@lwn.net,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: rdunlap@infradead.org, rostedt@goodmis.org,
senozhatsky@chromium.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
taichi.shimoyashiki@sony.com, daniel.palmer@sony.com,
anandakumar.balasubramaniam@sony.com
Subject: Re: [PATCH v6 2/2] tty/sysrq: Replay kernel log messages on consoles via sysrq
Date: Mon, 8 Apr 2024 11:23:32 +0530 [thread overview]
Message-ID: <ZhOGXGwGTWK5JVuU@sreenath.vijayan@sony.com> (raw)
In-Reply-To: <cc3b9b1aae60a236c6aed1dc7b0ffa2c7cd1f183.1710220326.git.sreenath.vijayan@sony.com>
On Wed, Mar 13, 2024 at 03:52:52PM +0530, Sreenath Vijayan wrote:
> When terminal is unresponsive, one cannot use dmesg to view
> the printk ring buffer messages. Also, syslog services may be
> disabled, especially on embedded systems, to check the messages
> after a reboot. In this scenario, replay the messages in printk
> ring buffer on consoles via sysrq by pressing sysrq+R.
>
> The console loglevel will determine which all kernel log messages
> are displayed. The messages will be displayed only when
> console_trylock() succeeds. Users could repeat the sysrq key when
> it fails. If the owner of console subsystem lock is stuck,
> repeating the key won't work.
>
> Suggested-by: Petr Mladek <pmladek@suse.com>
> Signed-off-by: Shimoyashiki Taichi <taichi.shimoyashiki@sony.com>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> Signed-off-by: Sreenath Vijayan <sreenath.vijayan@sony.com>
> ---
> Documentation/admin-guide/sysrq.rst | 9 +++++++++
> drivers/tty/sysrq.c | 13 ++++++++++++-
> 2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 2f2e5bd440f9..a85b3384d1e7 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -161,6 +161,8 @@ Command Function
> will be printed to your console. (``0``, for example would make
> it so that only emergency messages like PANICs or OOPSes would
> make it to your console.)
> +
> +``R`` Replay the kernel log messages on consoles.
> =========== ===================================================================
>
> Okay, so what can I use them for?
> @@ -211,6 +213,13 @@ processes.
> "just thaw ``it(j)``" is useful if your system becomes unresponsive due to a
> frozen (probably root) filesystem via the FIFREEZE ioctl.
>
> +``Replay logs(R)`` is useful to view the kernel log messages when system is hung
> +or you are not able to use dmesg command to view the messages in printk buffer.
> +User may have to press the key combination multiple times if console system is
> +busy. If it is completely locked up, then messages won't be printed. Output
> +messages depend on current console loglevel, which can be modified using
> +sysrq[0-9] (see above).
> +
> Sometimes SysRq seems to get 'stuck' after using it, what can I do?
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 02217e3c916b..e5974b8239c9 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -450,6 +450,17 @@ static const struct sysrq_key_op sysrq_unrt_op = {
> .enable_mask = SYSRQ_ENABLE_RTNICE,
> };
>
> +static void sysrq_handle_replay_logs(u8 key)
> +{
> + console_replay_all();
> +}
> +static struct sysrq_key_op sysrq_replay_logs_op = {
> + .handler = sysrq_handle_replay_logs,
> + .help_msg = "replay-kernel-logs(R)",
> + .action_msg = "Replay kernel logs on consoles",
> + .enable_mask = SYSRQ_ENABLE_DUMP,
> +};
> +
> /* Key Operations table and lock */
> static DEFINE_SPINLOCK(sysrq_key_table_lock);
>
> @@ -519,7 +530,7 @@ static const struct sysrq_key_op *sysrq_key_table[62] = {
> NULL, /* O */
> NULL, /* P */
> NULL, /* Q */
> - NULL, /* R */
> + &sysrq_replay_logs_op, /* R */
> NULL, /* S */
> NULL, /* T */
> NULL, /* U */
> --
> 2.25.1
>
Hi,
Kindly let me know if there are any review comments for the above changes.
Regards,
Sreenath
next prev parent reply other threads:[~2024-04-08 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 10:17 [PATCH v6 0/2] Add support to replay kernel log on consoles via sysrq Sreenath Vijayan
2024-03-13 10:20 ` [PATCH v6 1/2] printk: Add function to replay kernel log on consoles Sreenath Vijayan
2024-05-22 15:18 ` Petr Mladek
2024-05-23 5:52 ` Sreenath Vijayan
2024-03-13 10:22 ` [PATCH v6 2/2] tty/sysrq: Replay kernel log messages on consoles via sysrq Sreenath Vijayan
2024-04-08 5:53 ` Sreenath Vijayan [this message]
2024-05-22 15:31 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhOGXGwGTWK5JVuU@sreenath.vijayan@sony.com \
--to=sreenath.vijayan@sony.com \
--cc=anandakumar.balasubramaniam@sony.com \
--cc=corbet@lwn.net \
--cc=daniel.palmer@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=taichi.shimoyashiki@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).