From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guanbing Huang <albanhuang@outlook.com>
Cc: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com,
linux-acpi@vger.kernel.org, tony@atomide.com,
john.ogness@linutronix.de, yangyicong@hisilicon.com,
jirislaby@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, lvjianmin@loongson.cn,
albanhuang@tencent.com, tombinfan@tencent.com
Subject: Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()
Date: Wed, 3 Apr 2024 13:06:22 +0300 [thread overview]
Message-ID: <Zg0qHs-wzG9y0lQt@smile.fi.intel.com> (raw)
In-Reply-To: <Zg0nSz7QSBjIQ_XP@smile.fi.intel.com>
On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:
One more thing, the Subject should start with "serial: port: ..."
And also should have PNP IRQ (capitalized).
> > The function __uart_read_properties doesn't cover pnp devices, so add irq
>
> __uart_read_properties()
>
> PNP
> IRQ
>
> > processing for pnp devices in the branch.
>
> PNP
>
> ...
>
> > #include <linux/property.h>
> > #include <linux/serial_core.h>
> > #include <linux/spinlock.h>
> > +#include <linux/pnp.h>
>
> Keep it ordered (in this context it should go before property.h).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-03 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240403074130.93811-1-albanhuang@outlook.com>
2024-04-03 7:41 ` [PATCH v4 1/3] pnp: Add dev_is_pnp() macro Guanbing Huang
2024-04-03 9:54 ` Andy Shevchenko
2024-04-03 7:41 ` [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties() Guanbing Huang
2024-04-03 9:54 ` Andy Shevchenko
2024-04-03 10:06 ` Andy Shevchenko [this message]
2024-04-03 7:41 ` [PATCH v4 3/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang
2024-04-03 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg0qHs-wzG9y0lQt@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=albanhuang@outlook.com \
--cc=albanhuang@tencent.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=tombinfan@tencent.com \
--cc=tony@atomide.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).