From: Michael Ellerman <mpe@ellerman.id.au>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood
Date: Mon, 08 Apr 2024 15:29:56 +1000 [thread overview]
Message-ID: <87sezwbewb.fsf@mail.lhotse> (raw)
In-Reply-To: <2cb53463-897b-8f3f-7238-9fe87622b54d@linux-m68k.org>
Finn Thain <fthain@linux-m68k.org> writes:
> On Fri, 5 Apr 2024, Michael Ellerman wrote:
>
>> I assume you have tested this on an actual pmac, as well as qemu?
>>
>
> I tested the patched driver and its console functionality using Zilog SCC
> hardware in a Mac IIci, as well as QEMU's q800 virtual machine.
>
> That should suffice from a code coverage point-of-view, since
> pmz_receive_chars() is portable and independent of CONFIG_PPC_PMAC.
>
> Moreover, I don't know how to get my PowerMac G3 to execute the kludge
> that's to be removed here. I can't prove it's impossible, though.
Thanks. That's good enough for me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
prev parent reply other threads:[~2024-04-08 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 23:24 [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood Finn Thain
2024-04-05 3:10 ` Michael Ellerman
2024-04-06 3:21 ` Finn Thain
2024-04-08 5:29 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sezwbewb.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=andy.shevchenko@gmail.com \
--cc=aneesh.kumar@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=fthain@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).