From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH 2/4] serial: sh-sci: describe locking requirements for invalidating RXDMA
Date: Mon, 6 May 2024 13:40:18 +0200 [thread overview]
Message-ID: <20240506114016.30498-8-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20240506114016.30498-6-wsa+renesas@sang-engineering.com>
Make sure everyone knows that calling this function needs protection.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/tty/serial/sh-sci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index a6f3517dce74..09eb0c824b10 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -1258,6 +1258,7 @@ static int sci_dma_rx_find_active(struct sci_port *s)
return -1;
}
+/* Must only be called with uart_port_lock taken */
static void sci_dma_rx_chan_invalidate(struct sci_port *s)
{
unsigned int i;
--
2.43.0
next prev parent reply other threads:[~2024-05-06 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 11:40 [PATCH 0/4] serial: sh-sci: response to Dirk's bugreport Wolfram Sang
2024-05-06 11:40 ` [PATCH 1/4] serial: sh-sci: protect invalidating RXDMA on shutdown Wolfram Sang
2024-05-06 11:40 ` Wolfram Sang [this message]
2024-05-06 11:40 ` [PATCH 3/4] serial: sh-sci: let timeout timer only run when DMA is scheduled Wolfram Sang
2024-05-06 11:40 ` [PATCH 4/4] serial: sh-sci: simplify locking when re-issuing RXDMA fails Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506114016.30498-8-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).