From: lumingyindetect@126.com
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
Subject: [PATCH] "drivers:Fixed memory leak in /linux/drivers/tty/serial/8250/8250_lpss.c file.
Date: Fri, 26 Apr 2024 03:19:39 +0100 [thread overview]
Message-ID: <20240426021939.1083521-1-lumingyindetect@126.com> (raw)
From: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
In the lpss8250_probe function in the file /linux/drivers/tty/serial/8250/8250_lpss.c, there were certain return paths where pci_free_irq_vectors was not called to release memory related to pdev, leading to a memory leak. This commit fixes that issue."
Signed-off-by: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
---
drivers/tty/serial/8250/8250_lpss.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
index 776ec1ef29d6..2bb86f9cad5b 100644
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -344,11 +344,11 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id)
uart.port.mapbase = pci_resource_start(pdev, 0);
uart.port.membase = pcim_iomap(pdev, 0, 0);
if (!uart.port.membase)
- return -ENOMEM;
+ goto early_err_exit;
ret = lpss->board->setup(lpss, &uart.port);
if (ret)
- return ret;
+ goto early_err_exit;
dw8250_setup_port(&uart.port);
@@ -367,6 +367,7 @@ static int lpss8250_probe(struct pci_dev *pdev, const struct pci_device_id *id)
err_exit:
lpss->board->exit(lpss);
+early_err_exit:
pci_free_irq_vectors(pdev);
return ret;
}
--
2.25.1
next reply other threads:[~2024-04-26 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 2:19 lumingyindetect [this message]
2024-04-26 9:06 ` [PATCH] "drivers:Fixed memory leak in /linux/drivers/tty/serial/8250/8250_lpss.c file Ilpo Järvinen
2024-04-26 14:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426021939.1083521-1-lumingyindetect@126.com \
--to=lumingyindetect@126.com \
--cc=11570291+yin-luming@user.noreply.gitee.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).