From: Konstantin Pugin <rilian.la.te@ya.ru>
Cc: "Konstantin Pugin" <ria.freelander@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Lech Perczak" <lech.perczak@camlingroup.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH v4 0/3] add support for EXAR XR20M1172 UART
Date: Fri, 19 Apr 2024 15:45:00 +0300 [thread overview]
Message-ID: <20240419124506.1531035-1-rilian.la.te@ya.ru> (raw)
From: Konstantin Pugin <ria.freelander@gmail.com>
EXAR XR20M1172 UART is mostly SC16IS762-compatible, but
it has additional register which can change UART multiplier
to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this
flag to guard access to its specific DLD register. It seems than
other EXAR SPI UART modules also have this register, but I tested
only XR20M1172.
Yes, in datasheet this register is called "DLD - Divisor Fractional"
or "DLD - Divisor Fractional Register", calling depends on datasheet
version.
I am sorry about too many submissions and top post reply. About second -
I do not know how to reply properly to this ML from GMail phone app. About first - I just
get very good feedback from Andy Shevchenko, and want to fix his review picks ASAP.
Changes in v2:
- use full name in git authorship
Changes in v3:
- change formatting of commit messages to unify width
- rework commit messages according to code review
- add XR20M117X namespace for EXAR-specific register
- do not use UPF_MAGIC_MULTIPLIER for checking EXAR chip,
use s->devtype directly
- replace while loop to fls function and expanded check
- sort compatibles
- reformat multiline comment.
Changes in v4:
- rebase onto tty-next branch
- added Kconfig mention of the chip
- used rounddown_power_of_two instead of fls and manual shift
- used FIELD_PREP instead of custom macro
- removed has_dld bit from common struct, replaced by check function,
which checks directly by s->devtype
- fixed tab count
- properly apply Vladimir Zapolskiy's tag to patch 2 only
Konstantin Pugin (3):
serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND
dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART
serial: sc16is7xx: add support for EXAR XR20M1172 UART
.../bindings/serial/nxp,sc16is7xx.yaml | 1 +
drivers/tty/serial/Kconfig | 18 +++---
drivers/tty/serial/sc16is7xx.c | 62 +++++++++++++++++--
drivers/tty/serial/sc16is7xx_i2c.c | 1 +
drivers/tty/serial/sc16is7xx_spi.c | 1 +
5 files changed, 70 insertions(+), 13 deletions(-)
base-commit: c6795fbffc4547b40933ec368200bd4926a41b44
--
2.34.1
next reply other threads:[~2024-04-19 12:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 12:45 Konstantin Pugin [this message]
2024-04-19 12:45 ` [PATCH v4 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Konstantin Pugin
2024-04-19 13:29 ` Hugo Villeneuve
2024-04-19 13:46 ` Konstantin P.
2024-04-19 12:45 ` [PATCH v4 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART Konstantin Pugin
2024-04-19 13:32 ` Krzysztof Kozlowski
2024-04-19 13:49 ` Konstantin P.
2024-04-19 14:01 ` Krzysztof Kozlowski
2024-04-19 14:07 ` Conor Dooley
2024-04-19 14:17 ` Konstantin P.
2024-04-19 14:24 ` Krzysztof Kozlowski
2024-04-19 14:34 ` Konstantin P.
2024-04-19 14:52 ` Andy Shevchenko
2024-04-19 14:56 ` Conor Dooley
2024-04-19 14:49 ` Andy Shevchenko
2024-04-19 12:45 ` [PATCH v4 3/3] serial: sc16is7xx: add support for EXAR " Konstantin Pugin
2024-04-20 6:04 ` kernel test robot
2024-04-20 7:28 ` kernel test robot
2024-04-19 13:42 ` [PATCH v4 0/3] " Hugo Villeneuve
2024-04-19 13:47 ` Konstantin P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419124506.1531035-1-rilian.la.te@ya.ru \
--to=rilian.la.te@ya.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ria.freelander@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).